Add new SendWithRetry API method #172
Merged
+455
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the begin I tried it with https://github.com/App-vNext/Polly and it worked quite good, but it felt like cracking a nut with a sledgehammer. I had in the integration some dependency issues, since some dependencies used different polly versions 🤔 Since I had the feeling that in the past the community reacts a bit alergic against new dependencies I didn't wanted to introduce a new dependency which might make some more issues for such a simple thing. This is the reason why I added an own simple implementation. If we need more things of it, then we can revise it and remove the own thing.
I added the
SendWithRetry
method to the API, which means all commands currently have this new API method.I did a reference implementation for the Cancel workflow instance command all others currently thrown not implemented exceptions.