Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new SendWithRetry API method #172

Merged
merged 1 commit into from
Sep 13, 2020
Merged

Add new SendWithRetry API method #172

merged 1 commit into from
Sep 13, 2020

Conversation

ChrisKujawa
Copy link
Collaborator

At the begin I tried it with https://github.com/App-vNext/Polly and it worked quite good, but it felt like cracking a nut with a sledgehammer. I had in the integration some dependency issues, since some dependencies used different polly versions 🤔 Since I had the feeling that in the past the community reacts a bit alergic against new dependencies I didn't wanted to introduce a new dependency which might make some more issues for such a simple thing. This is the reason why I added an own simple implementation. If we need more things of it, then we can revise it and remove the own thing.

I added the SendWithRetry method to the API, which means all commands currently have this new API method.
I did a reference implementation for the Cancel workflow instance command all others currently thrown not implemented exceptions.

@ChrisKujawa ChrisKujawa changed the title Add new sendWithRetry API method Add new SendWithRetry API method Sep 13, 2020
@ChrisKujawa ChrisKujawa merged commit e8421da into master Sep 13, 2020
@ChrisKujawa ChrisKujawa deleted the zell-retry branch September 13, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant