-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(client/ C#): Update TopologyRequestCommand and UpdateRetriesCommand for retries #329
Feat(client/ C#): Update TopologyRequestCommand and UpdateRetriesCommand for retries #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @askalik thanks so much for your contribution :)
Could you please create two separate PR's next time, to separate the concerns :)
You currently have two commits, please squash them (the first one has no real change).
Sorry, I had to forget to mention, we also need to test this. For that please add also a TestCaseData object on this provider https://github.com/camunda-community-hub/zeebe-client-csharp/blob/master/Client.UnitTests/TestDataProvider.cs, such that the parameterized test is running also for this command. Feel free to ask any questions you might have.
update to re-add send method that was removed erroneously. Feature: add retries logic Adding retry logic to TopologyRequestCommand and UpdateRetriesCommand feat(client/ C#): allow with retry updates the UpdateRetriesCommandStep1 and TopologyRequestCommand to use FinalCommandWithRetrySteps. Issue #183 #184
@Zelldon I squashed the commits, and re-added the send method. Working on getting the test updated. Is it the topology that is to be added, updated with retries - or both? |
Thanks @askalik yes please add two new test case data objects here https://github.com/camunda-community-hub/zeebe-client-csharp/blob/master/Client.UnitTests/TestDataProvider.cs#L13 Example for the topology:
|
…Retries feat: add retries update to re-add send method that was removed erroneously. Feature: add retries logic Adding retry logic to TopologyRequestCommand and UpdateRetriesCommand feat(client/ C#): allow with retry updates the UpdateRetriesCommandStep1 and TopologyRequestCommand to use FinalCommandWithRetrySteps. Issue #183 #184
…h-retries' of https://github.com/askalik/zeebe-client-csharp into feature-TopologyRequestCommand-UpdateRetriesCommand-with-retries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎖️
yield return new TestCaseData( | ||
new TopologyRequest | ||
{ | ||
ProcessInstanceKey = 12113 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry my example was bit wrong 🙈 here the key makes no sense, I'm wondering that this compiles 😆
But it is fine I can fix it later :) I will merge it anyway Thanks @askalik for all your efforts 🚀
Previous PR was merged without checking CI action, it misses several imports, parameters or wrong types have been used. We should take a closer look next time. related PR #329
closes #184 , #183
Updated the interfaces, methods, and main application to use asyncRetryStrategy.
Please let me know if I have missed anything