Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#669 externalise dependency #670

Conversation

thompson-tomo
Copy link
Contributor

closes #669

@CLAassistant
Copy link

CLAassistant commented Apr 26, 2024

CLA assistant check
All committers have signed the CLA.

ChrisKujawa
ChrisKujawa approved these changes May 3, 2024
Copy link
Collaborator

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at our contribution guide, we have some guidelines for the commit messages https://github.com/camunda/zeebe/blob/main/CONTRIBUTING.md#commit-message-guidelines

Please adjust your commit header to something likebuild: remove dataflow dependency

And please add some more description to why this change was necessary, so it is also clear for the afterworld

This allows the framework to be the source of the dependency rather externally sourcing. This is to avoid potential conflicts.

closes camunda-community-hub#669
@thompson-tomo thompson-tomo force-pushed the chore/#669_MinimiseDependencies branch from e4e7920 to 5d9f8ee Compare May 5, 2024 22:10
@thompson-tomo
Copy link
Contributor Author

@Zelldon commit message has been updated as requested.

@thompson-tomo thompson-tomo requested a review from ChrisKujawa May 5, 2024 22:11
Copy link
Collaborator

@ChrisKujawa ChrisKujawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍🏼

@ChrisKujawa ChrisKujawa merged commit 7550c64 into camunda-community-hub:main May 7, 2024
5 checks passed
@thompson-tomo thompson-tomo deleted the chore/#669_MinimiseDependencies branch May 7, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I can use the client with less dependencies
3 participants