Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend loading as an external exporter via the JAR path for Zeebe 1.0.1 #188

Merged
merged 2 commits into from
Jun 12, 2021

Conversation

npepinpe
Copy link
Collaborator

@npepinpe npepinpe commented Jun 12, 2021

Description

This PR updates the QA tests and the documentation to make it explicit that the recommended way of loading the exporter is as an external JAR (e.g. using the jarPath configuration option) that is not located in the lib/ folder of the Zeebe broker. This will avoid hard to diagnose issues which may stem from unpredictable dependency version conflicts.

Pull Request Checklist

  • All commit messages match our commit message guidelines
  • The submitting code follows our code style
  • If submitting code, please run mvn clean install -DskipTests locally before committing
  • Ensure all PR checks are green

npepinpe added 2 commits June 12, 2021 14:58
Updates QA tests to use Zeebe 1.0.1 and load the exporter as an external
exporter and not via the class path.
Updates docs to notify users that from 1.0.1, Zeebe can correctly load
the Kafka exporter as an external JAR and it's not necessary to load
directly from within the classpath. This helps avoid potential
dependency version conflicts.
@npepinpe npepinpe added the enhancement New feature or request label Jun 12, 2021
@npepinpe npepinpe self-assigned this Jun 12, 2021
@npepinpe npepinpe merged commit 5ace672 into master Jun 12, 2021
@npepinpe npepinpe deleted the np-external-jar branch June 12, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant