Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v5.2.0 #393

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Prepare v5.2.0 #393

merged 3 commits into from
Nov 20, 2024

Conversation

nikku
Copy link
Member

@nikku nikku commented Nov 20, 2024

Proposed Changes

Bumps dependencies + prepares v5.2.0 release. A lot of fixed upstream bugs depend on this.

Search now works reliably, with UX improvements:

capture o1oRv0_optimized

Properties panel can now be focused, so undo/redo is possible also outside of inputs:

capture Mp30XN_optimized

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@misiekhardcore
Copy link
Contributor

misiekhardcore commented Nov 25, 2024

How do the code reviews work in modeling team? Shouldn't there be at least one approval before merging? Or it depends on the change being made?

@barmac
Copy link
Contributor

barmac commented Nov 25, 2024

It depends on the change. I'd rather not yolo-merge features or fixes, but a changelog or dependency update is OK if you know what you are doing. Notice that the changes from this PR were already reviewed in the upstream deps' PRs, and also in camunda/camunda-modeler#4711

@nikku
Copy link
Member Author

nikku commented Nov 26, 2024

I'd rather not yolo-merge features or fixes, but a changelog or dependency update is OK if you know what you are doing.

@misiekhardcore Your merge, your responsibility, and if you mess things up and don't allow others to help / guard you, you gotta do the extra hours to fix it.

Additional context: Our world is a little more complex than operate, so we sometimes trade-off things.

@misiekhardcore
Copy link
Contributor

Our world is a little more complex than operate

I don't get this part

@nikku
Copy link
Member Author

nikku commented Nov 26, 2024

Sorry, not meant Operate, but single application. 🙂

For example to implement a feature E2E we need at least 5 PRs, and we try to carefully balance to meet both "work flows" and "4 eyes principle" criteria.

@misiekhardcore
Copy link
Contributor

Maybe the reviewing process can be somehow improved if it is a bottleneck right now. I mean for this kind of changes then maybe it is fine to just merge the PR if you know what you are doing, but in general maybe there is something we can improve to minimise the amount of PRs we have to merge before they get a review? Or I am just overthinking this?

@barmac
Copy link
Contributor

barmac commented Nov 26, 2024

@misiekhardcore @nikku Let's discuss it outside of this PR as it's unrelated to the v5.2.0 release.
We could have an issue in https://github.com/bpmn-io/internal-docs for an async proposal, or an additional topic in the weekly for sync discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants