Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update dependency @testing-library/dom to v10 #103

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Apr 8, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@testing-library/dom ^9.3.1 -> ^10.0.0 age adoption passing confidence

Release Notes

testing-library/dom-testing-library (@​testing-library/dom)

v10.0.0

Compare Source

Bug Fixes
  • use defineProperty on the error object instead of setting the message directly (#​1268) (3580f25), closes #​1259
Features
BREAKING CHANGES
  • Minimum supported Node.js version is 18.0
  • New version of aria-query changes various roles. Check out the changed tests in 2c57055 to get an overview about what changed.

v9.3.4

Compare Source

Bug Fixes

v9.3.3

Compare Source

Bug Fixes
  • use defineProperty on the error object instead of setting the message directly (#​1261) (270a531), closes #​1259

v9.3.2

Compare Source

Bug Fixes

Configuration

📅 Schedule: Branch creation - "after 10pm,before 5:00am" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Updates a dependency label Apr 8, 2024
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Apr 8, 2024
@nikku
Copy link
Member

nikku commented Apr 9, 2024

@philippfromme Could you have a look into this PR? It looks like something is odd with the newly introduced asset tests. I do not have a Windows machine at hand though.

Copy link
Contributor Author

renovate bot commented Apr 9, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@nikku nikku requested a review from philippfromme April 10, 2024 07:00
@philippfromme
Copy link
Contributor

I can reproduce this on my machine.

@philippfromme
Copy link
Contributor

It seems like copying CSS assets on Windows never worked but we didn't notice since we didn't verify it for a long time and I've never done a release. Might be related to vladshcherbin/rollup-plugin-copy#69.

@nikku
Copy link
Member

nikku commented Apr 16, 2024

If that helps, let's migrate over to https://modern-web.dev/docs/building/rollup-plugin-copy/.

@philippfromme philippfromme merged commit c334ddb into main Apr 16, 2024
11 checks passed
@philippfromme philippfromme deleted the renovate/testing-library-dom-10.x branch April 16, 2024 08:33
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates a dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants