Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(camunda-bpm-run): Add WADL Config Docs #1678

Merged
merged 3 commits into from
Sep 16, 2024
Merged

chore(camunda-bpm-run): Add WADL Config Docs #1678

merged 3 commits into from
Sep 16, 2024

Conversation

psavidis
Copy link
Contributor

@psavidis psavidis commented Sep 13, 2024 •
edited
Loading

@psavidis psavidis self-assigned this Sep 13, 2024
@psavidis psavidis changed the title chore(721-to-722): Fix code review points chore(camunda-bpm-run): Add WADL Config Docs Sep 13, 2024
@psavidis
Copy link
Contributor Author

psavidis commented Sep 13, 2024 •
edited
Loading

Notes to the Reviewer

Context: Exposure of WADL File Endpoint via the REST API
What: This PR adds docs for the newly added property which controls if the wadl endpoint will be accessible or not through the REST API.

@psavidis psavidis marked this pull request as ready for review September 13, 2024 07:51
@psavidis psavidis mentioned this pull request Sep 13, 2024
Closed
5 tasks
danielkelemen
danielkelemen reviewed Sep 16, 2024
View reviewed changes
Copy link
Member

@danielkelemen danielkelemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. I added two notes, let me know what you think.

content/user-guide/camunda-bpm-run.md Outdated Show resolved Hide resolved
content/user-guide/camunda-bpm-run.md Outdated Show resolved Hide resolved
@psavidis @danielkelemen
Apply suggestions from code review
3fa23c3 
Co-authored-by: Daniel Kelemen <danielkelemen@users.noreply.github.com>
@psavidis psavidis merged commit c3f6b93 into master Sep 16, 2024
1 check passed
@psavidis psavidis deleted the 4508-add-documentation branch September 16, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielkelemen danielkelemen danielkelemen approved these changes

Assignees

@psavidis psavidis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psavidis @danielkelemen