Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update forms library (part 2) #2174

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Update forms library (part 2) #2174

merged 7 commits into from
Jul 18, 2023

Conversation

pinussilvestrus
Copy link
Contributor

@pinussilvestrus pinussilvestrus commented Jun 6, 2023 •
edited
Loading

Description

This is a follow up of #2169. This includes the features that won't be part of the next alphas, so we can wait with reviewing it.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pinussilvestrus pinussilvestrus changed the base branch from main to update-forms-library June 6, 2023 08:41
@akeller akeller added the component:modeler Issues related with Modeler project label Jun 6, 2023
Base automatically changed from update-forms-library to main June 12, 2023 14:49
@pinussilvestrus
Copy link
Contributor Author

Update: as this didn't make it into the alpha3 release, I will open this up for review after the release.

@pinussilvestrus pinussilvestrus marked this pull request as ready for review July 12, 2023 07:07
@pinussilvestrus
Copy link
Contributor Author

This is ready for review now 👍

vsgoulart
vsgoulart previously approved these changes Jul 12, 2023
View reviewed changes
christinaausley
christinaausley requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment for clarification here.

docs/components/modeler/forms/configuration/forms-config-options.md Outdated Show resolved Hide resolved
@christinaausley
Copy link
Contributor

@pinussilvestrus Feel free to squash and merge when you are ready 👍

@pinussilvestrus pinussilvestrus merged commit 26f5043 into main Jul 18, 2023
3 checks passed
@pinussilvestrus pinussilvestrus deleted the update-forms-library-part-2 branch July 18, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaausley christinaausley christinaausley approved these changes

@vsgoulart vsgoulart vsgoulart left review comments

@Skaiir Skaiir Awaiting requested review from Skaiir

Assignees

@pinussilvestrus pinussilvestrus

Labels
component:modeler Issues related with Modeler project
Projects
Developer Experience
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pinussilvestrus @christinaausley @vsgoulart @akeller