Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(redhat-openshift.md): use correct env var name #2276

Merged
merged 4 commits into from
Jul 13, 2023
Merged

Conversation

falko
Copy link
Member

@falko falko commented Jun 29, 2023

I tested together with a prospect in their Open Shift cluster that this is the right configuration.

Description

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

I tested together with a prospect in their Open Shift cluster that this is the right configuration.
@falko
Copy link
Member Author

falko commented Jun 29, 2023

This needs backporting to all versions.

@falko falko requested a review from aabouzaid June 29, 2023 21:52
@christinaausley christinaausley added the component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed label Jun 30, 2023
@falko
Copy link
Member Author

falko commented Jul 1, 2023

@christinaausley anything else you need from me?

@akeller
Copy link
Member

akeller commented Jul 10, 2023

@camunda/distribution can you confirm these changes are correct?

@aabouzaid
Copy link
Member

@akeller that should be reviewed by the Operate/Tasklist team since it's app config.

@akeller akeller added component:operate Issues related with Operate project component:tasklist Issues related with Tasklist project labels Jul 12, 2023
@akeller akeller requested review from johanwelgemoed and marcosgvieira and removed request for aabouzaid and jessesimpson36 July 12, 2023 15:58
@akeller
Copy link
Member

akeller commented Jul 12, 2023

@johanwelgemoed @marcosgvieira can you confirm these environment variables are correct for Operate and Tasklist config?

@johanwelgemoed
Copy link
Contributor

@akeller Looked at it together with Svetlana, she approved from Operate side.

Copy link
Contributor

@marcosgvieira marcosgvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that this is correct.

@akeller
Copy link
Member

akeller commented Jul 13, 2023

Thank you, everyone!

@akeller akeller merged commit 93987b1 into main Jul 13, 2023
7 checks passed
@akeller akeller deleted the falko-patch-2 branch July 13, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:operate Issues related with Operate project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:tasklist Issues related with Tasklist project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants