Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct merge conflict in Tasklist API #2293

Merged
merged 1 commit into from
Jul 10, 2023
Merged

Conversation

akeller
Copy link
Member

@akeller akeller commented Jul 6, 2023

Description

image

This presented itself in the Bing Webmaster tools console -

There are multiple <h1> tags on the page.

Looks like there was a merge conflict and this PR cleans that up. I did not see any issues in 8.1 or 8.0.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@akeller akeller added kind/bug Issues related with bugs in the documentation component:tasklist Issues related with Tasklist project component:docs Documentation improvements, including new or updated content labels Jul 6, 2023
@akeller akeller self-assigned this Jul 6, 2023
@akeller
Copy link
Member Author

akeller commented Jul 6, 2023

@marcosgvieira can you or a delegate from the Tasklist team confirm this change is correct? It was a bit difficult for me to tell.

@marcosgvieira
Copy link
Contributor

@ce-dmelnych can you please give us a hand on this one?

@ce-dmelnych
Copy link
Contributor

@ce-dmelnych can you please give us a hand on this one?

Sure, I'll work on it.

Copy link
Contributor

@ce-dmelnych ce-dmelnych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @akeller!
I can confirm that the changes are correct. After resolving the merge conflict, the links are working as expected.

@akeller akeller merged commit 4b5fc4a into main Jul 10, 2023
@akeller akeller deleted the tasklist-api-merge-conflict branch July 10, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:tasklist Issues related with Tasklist project kind/bug Issues related with bugs in the documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants