Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive(1.0) isolation: automated steps #2318

Merged

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Jul 11, 2023

Description

Part of #2185.

Note: This PR will be merged into the unsupported/1.0 branch, and will never make it to main.

Note: This PR will not go green. There are manual cleanup steps coming in a future PR that will make it go green.

Continues the process of archival/isolation for version 1.0. Includes the following steps, which a computer did for me:

  1. Exclude all other versions from version manifest file
  2. Prevent the 1.0 site from being crawled
  3. Fix the Dockerfile for local debugging
  4. Update the swizzled theme components for the isolated version.
  5. (new!) Update CI workflows. Note that feat(archiving): Automate workflow updates #2317 takes care of adding this new automated step to main!

Proof that item 5, updating the CI workflows, is properly automated

Here are a couple images showing the diff on this PR on the left, and the diff of #2235 on the right, specifically the workflow changes.

image image

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz self-assigned this Jul 11, 2023
@pepopowitz pepopowitz mentioned this pull request Jul 11, 2023
@pepopowitz pepopowitz requested a review from akeller July 11, 2023 21:42
@pepopowitz
Copy link
Collaborator Author

@akeller I forgot to include the new CI workflows before you reviewed 😅

They're in there now.

@pepopowitz pepopowitz added kind/cleanup Issues related with clean-up the documentation dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions labels Jul 11, 2023
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed they were coming in another PR 🤣 but yes this does look better and more complete.

@pepopowitz pepopowitz merged commit c028e3d into unsupported/1.0 Jul 12, 2023
7 of 8 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/2185-archive-1-0/step-2-automated-tasks branch July 12, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions kind/cleanup Issues related with clean-up the documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants