-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split element templates docs into C7 and C8 #2369
Conversation
56ce426
to
fab942b
Compare
@CatalinaMoisuc @christian-konrad Looking forward to your feedback :) |
@akeller Also looping you in here -- do you think it would be best to keep all C7-specific content in the Platform 7 docs? Maybe I'm misunderstanding here, and we should just apply the Platform 7 labels. |
@christinaausley We moved all Modeler docs (like Optimize docs) to docs.camunda.io. I like the clear separation here and the focus on C8. This is the right choice. In the future, if it makes sense to move or remove the C7 content, it will already be separate. For consistency with other C7 only docs, please add the label/badging. Note - I did not review the content in this PR. If you are looking for a content review, please add me as a reviewer, and I'll come back. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical review in latest commit 👍
@barmac @christian-konrad @sbuettner question for all of you: Do you see any reason why we should have the C7 documentation here and not in https://docs.camunda.org/manual/7.19/modeler/element-templates/? |
Please read Amara's comment above: #2369 (comment) Personally, I could live with both docs.camunda.io as single source of Modeler docs, and separate C7 and C8. However, as we have already moved Element Templates docs to docs.camunda.io before this PR, I'd rather not invest time in migrating them back to the legacy docs. |
I am with @CatalinaMoisuc here as we should try to split and not mix c7 & c8 content here but I can understand @barmac as well. No hard feelings. I think @akeller is right and we should try to phase out c7 content in the new docs eventually. |
@@ -8,6 +8,10 @@ description: "Element templates are a way to extend Camunda Modeler with domain- | |||
Element templates are currently available in BPMN diagrams only. | |||
::: | |||
|
|||
:::note |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This additional sentence that exists on the C7 page might also be useful here:
"Element templates are currently available in BPMN diagrams only.".
docs/components/modeler/desktop-modeler/element-templates/camunda-platform-7/about-templates.md
Outdated
Show resolved
Hide resolved
...ponents/modeler/desktop-modeler/element-templates/camunda-platform-7/additional-resources.md
Outdated
Show resolved
Hide resolved
docs/components/modeler/desktop-modeler/element-templates/camunda-platform-7/using-templates.md
Outdated
Show resolved
Hide resolved
@@ -477,67 +339,16 @@ If a user removes the value in the configured control, it will also remove the m | |||
|
|||
##### Supported Bindings | |||
|
|||
Camunda Platform 8 supports `optional` on the following binding types: | |||
The following binding types can be `optional`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barmac I suggest that some other Engineer from the core team cross-checks the differences between C7 and C8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
@@ -3,15 +3,12 @@ id: defining-templates | |||
title: Defining templates | |||
--- | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above @barmac let's have another Engineer from the core team review the technical differences between C7 and C8 templates.
docs/components/modeler/desktop-modeler/element-templates/defining-templates.md
Outdated
Show resolved
Hide resolved
...omponents/modeler/desktop-modeler/element-templates/camunda-platform-7/defining-templates.md
Outdated
Show resolved
Hide resolved
@@ -278,27 +239,17 @@ When set, the input field offers visual indications that a feel expression is ex | |||
|
|||
###### Supported types | |||
|
|||
Camunda Platform 8 supports `feel` on the following input types: | |||
The property `feel` is supported on the following input types: | |||
|
|||
- `String` | |||
- `Text` | |||
|
|||
#### Bindings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't find the binding type bpmn:Message#property
documented anywhere. Are we aware of that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I believe I overlooked this when I implemented the feature 🤡
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will be done via https://github.com/bpmn-io/internal-docs/issues/797
@@ -477,67 +339,16 @@ If a user removes the value in the configured control, it will also remove the m | |||
|
|||
##### Supported Bindings | |||
|
|||
Camunda Platform 8 supports `optional` on the following binding types: | |||
The following binding types can be `optional`: | |||
|
|||
- `zeebe:input` | |||
- `zeebe:output` | |||
- `zeebe:taskHeader` | |||
- `zeebe:property` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we forgot about bpmn:Message#zeebe:subscription#property
here (cf. https://github.com/bpmn-io/bpmn-js-element-templates/blob/main/src/cloud-element-templates/create/MessageZeebeSubscriptionBindingProvider.js#L39).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cf. #2369 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christinaausley, do we have anything in the style guide on "the modeler" vs. "Modeler"? We use both in this PR (and likely in the rest of the element template docs).
@barmac, for the content here (in this PR), this is only in the scope of Desktop Modeler? Or does some content also apply to Web Modeler? It's currently nested in Desktop Modeler, but if it applies to both modeling experiences, we should move it.
We should add badging to Camunda Platform 7 pages -
<span class="badge badge--platform">Camunda Platform 7 only</span>
.
I would even recommend to be more overt about the title of the pages - "Using templates in Camunda Platform 7" - but keeping them short in the sidebar. This way users have the most visual context between the sidebar, URL, page title, and breadcrumbs.
We need to be careful about duplicate content here, where Google chooses what page it wants to rank (not ideal). The two configuring-templates.md
are nearly identical. Changing the title on the Camunda Platform 7 page will help, but we should also change the metadata description. In the near future, do we see significant divergence in the content on these pages?
Hi Amara, thanks for looking into this.
The C7 part is for Desktop Modeler only. From the C8 part, "Defining templates" and others can be applied to both while "Configuring templates" is Desktop Modeler only.
I will do this.
Great idea. I will apply the titles.
Perhaps we could link from C7 part to C8 as canonical? WDYT? |
@pepopowitz this is related to the last item in #1143. Can we (easily) specify canonicals at all right now? ☝️ If no - @barmac, I'll monitor this with our SEO tools. AFAIK there are no negative consequences of duplicate content, just a potential lack of control with ranking. No action required for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a couple of thoughts on this PR:
-
What is really different is the
defining-templates
page. I propose to only change that page, and keep the other pages agnostic of C7 and C8. This helps us to keep things maintainable. -
As we discussed once in a while we also mix up app documentation ("configuring templates") and element template documentation ("defining templates", "about templates") here. We may want to consider to split these appart. ➡️ Element templates are, in different versions, supported across web and desktop, and hence shall be featured on the same level as Camunda Forms (one level up).
-
I'd personally de-emphasize Camunda 7, i.e. by introducing a
Define Templates
sub-folder with a landing page + a dedicatedLegacy (Camunda 7)
page:Element Templates Define Templates Camunda 7 (or Legacy) Define Templates
-
Even better, to avoid confusion, we could move Camunda 7 content to a dedicated
Camunda Desktop Modeler -> Camunda 7 -> Element Templates -> ...
section. Once that content is farther away both users and SEO will be confused less.
Unless docusaurus has fixed something in the last couple versions, I don't think there is an easy way to specify a canonical on an individual page. (See the notes I just added in #1143 (comment).) |
@CatalinaMoisuc and I discussed a few things on a call this morning:
This works for me, but that is several nested levels. Perhaps keeping things split up as easily as possible is a good place to start, and if there is still confusion we can always go a level deeper.
We do clearly define the product in the WCoE as "using Web Modeler/Desktop Modeler" as opposed to "the Web Modeler", but I don't think we've defined "modeler yet". If we are referring to Web Modeler/Desktop Modeler specifically, it should be documented as such. If we are referring to some external modeler, using "your modeler" is fine (though we should likely only be referring to our own product regardless, yeah?) |
373b2c3
to
41672a5
Compare
76730b5
to
f9ef228
Compare
Co-authored-by: Philipp Fromme <philippfromme@outlook.com>
f9ef228
to
6b47210
Compare
I just noticed that I missed to update the versioned docs. This is done via 6b47210 |
...onents/modeler/desktop-modeler/element-templates/defining-templates/c7-defining-templates.md
Outdated
Show resolved
Hide resolved
@barmac How can I continue to support you with this? Looking for any additional review? Anywhere I can assist? |
I've restructured the docs according to @akeller's comment. Since I am on vacation from today on, please feel free to make any adjustments, and I am looking forward to merging this :) Thank you @christinaausley @akeller @nikku @CatalinaMoisuc @philippfromme for support in making this contribution substantially better! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your patience and flexibility here @barmac! Enjoy your vacation 🏖️
Let's merge this. Thanks all. |
Description
This PR splits the element templates docs into C7 and C8 sections, with C8 being the primary source. The goal is to make the docs easier to read as the reader can focus on the platform they want to support. Read more in the issue linked below:
Closes https://github.com/bpmn-io/internal-docs/issues/663
Closes #1450
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.