Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive(1.1) fix: update icon URLs based on virtual directory #2428

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

pepopowitz
Copy link
Collaborator

@pepopowitz pepopowitz commented Aug 10, 2023

Note that this targets the unsupported/1.1 branch, and will not make it into main.

Description

Part of #2186.

Fixes the footer social icons in the unsupported/1.1 site.

The path to them is incorrect in these isolated sites, because they sit in a "virtual directory" named according to their version. So this one, for example, lives at unsupported.docs.camunda.io/1.1/. The footer icons are in the root in the main site, but here the path needs to be adjusted based on the /1.1/.

I'll update my automation changes from #2422 in a separate PR, so that I don't miss this on the next version archival.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz added kind/bug Issues related with bugs in the documentation dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions labels Aug 10, 2023
@pepopowitz pepopowitz self-assigned this Aug 10, 2023
@pepopowitz pepopowitz changed the title fix: update icon URLs based on virtual directory archive(1.1) fix: update icon URLs based on virtual directory Aug 10, 2023
@pepopowitz
Copy link
Collaborator Author

merging this sans-approval since it's not a published site yet. Happy to make changes if you catch anything in review.

@pepopowitz pepopowitz merged commit 84dad58 into unsupported/1.1 Aug 10, 2023
9 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/fix-footer-icons branch August 10, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions kind/bug Issues related with bugs in the documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant