Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archiving(1.1) exclude: remove version 1.1, part 1: reviewable steps #2430

Merged
merged 3 commits into from
Aug 11, 2023

Conversation

pepopowitz
Copy link
Collaborator

BLOCKED: by the unsupported/1.1 site not being in production yet.

Description

Part of #2186.

Includes the smaller items for removing version 1.1 from the main docs, to keep the PR in a reviewable state.

Included in this PR

  • Remove 1.1 from the version manifest file, so that it's not included in the deployed site

  • Redirect all 1.1 traffic to unsupported.docs.camunda.io/1.1 (or stage.unsupported.docs.camunda.io/1.1 for the staging build)

  • Move 1.1 to the "Unsupported versions" sub-list in the top nav version selector, redirecting to unsupported.docs.camunda.io/1.1:

    image

When should this change go live?

  • I intend to merge this on Friday, Aug 11, after I've deployed the unsupported/1.1 site to production.
  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@pepopowitz pepopowitz added kind/cleanup Issues related with clean-up the documentation hold This issue is parked, do not merge. dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions labels Aug 10, 2023
@pepopowitz pepopowitz self-assigned this Aug 10, 2023
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes as expected 🚀

@pepopowitz pepopowitz mentioned this pull request Aug 11, 2023
@pepopowitz pepopowitz removed the hold This issue is parked, do not merge. label Aug 11, 2023
@pepopowitz pepopowitz merged commit 4a95468 into main Aug 11, 2023
4 of 9 checks passed
@pepopowitz pepopowitz deleted the pepopowitz/2186-archive-1-1/exclude-reviewable branch August 11, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx Documentation infrastructure typically handled by the Camunda DX team epic:archive-old-versions kind/cleanup Issues related with clean-up the documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants