Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust step x references #3418

Merged
merged 3 commits into from
Mar 7, 2024
Merged

adjust step x references #3418

merged 3 commits into from
Mar 7, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Closes https://github.com/camunda/developer-experience/issues/255. To be added to this week's WCoE release.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Mar 6, 2024
@christinaausley christinaausley self-assigned this Mar 6, 2024
akeller
akeller previously approved these changes Mar 6, 2024
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was expecting to see Entra ID in here too - https://docs.camunda.io/docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider/?authPlatform=microsoftEntraId#configuration

Feel free to handle that separately because the steps are also referenced in the code snippet.

@christinaausley
Copy link
Contributor Author

I was expecting to see Entra ID in here too - https://docs.camunda.io/docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider/?authPlatform=microsoftEntraId#configuration

Feel free to handle that separately because they steps are also referenced in the code snippet.

I was looking at those and meant to add a comment -- will adjust in this PR!

@akeller akeller merged commit f75b8bd into main Mar 7, 2024
7 checks passed
@akeller akeller deleted the 255-step-references branch March 7, 2024 16:19
theburi pushed a commit that referenced this pull request Jun 5, 2024
* adjust step x references

* adjust remaining references

* adjust spacing
pepopowitz pushed a commit that referenced this pull request Oct 16, 2024
* adjust step x references

* adjust remaining references

* adjust spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants