Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(web-modeler): update design mode section to include information about Documentation property #3542

Merged
merged 2 commits into from
Apr 2, 2024
Merged

docs(web-modeler): update design mode section to include information about Documentation property #3542

merged 2 commits into from
Apr 2, 2024

Conversation

nithinssabu
Copy link
Contributor

@nithinssabu nithinssabu commented Mar 28, 2024 •
edited
Loading

Description

Changes related to https://github.com/camunda/product-hub/issues/2027

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@github-actions GitHub Actions
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.

  • docs/components/modeler/web-modeler/design-your-process.md
  • docs/components/modeler/web-modeler/img/design-mode.png

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@nithinssabu nithinssabu requested review from a team, marstamm, barmac, wollefitz and christinaausley and removed request for a team, marstamm and barmac March 28, 2024 12:44
@christinaausley christinaausley added component:modeler Issues related with Modeler project target:8.5 labels Mar 28, 2024
@christinaausley
Copy link
Contributor

I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.

We checked this box, but this is only for the next version of docs, yes?

@nithinssabu
Copy link
Contributor Author

We checked this box, but this is only for the next version of docs, yes?

Yes, it's only for next, but in that case am I not supposed to check the box? The way it's phrased, to me it looks like a reminder and should also check it because it says "or they are not for an already released version"

@christinaausley
Copy link
Contributor

  • or they are not for an already released version.

You're right 😄 Sorry, my head has been in the code editor clouds and I was skimming.

@nithinssabu nithinssabu merged commit 9e33e78 into main Apr 2, 2024
6 checks passed
@nithinssabu nithinssabu deleted the wm-design-mode-documentation branch April 2, 2024 07:59
theburi pushed a commit that referenced this pull request Apr 3, 2024
@nithinssabu @theburi
docs(web-modeler): update design mode section to include information …
a255ba0 
…about Documentation property (#3542)

* docs(web-modeler): update design mode section to include information about Documentation property

* docs(web-modeler): remove PII from screenshot
theburi pushed a commit that referenced this pull request Jun 5, 2024
@nithinssabu @theburi
docs(web-modeler): update design mode section to include information …
ebf954d 
…about Documentation property (#3542)

* docs(web-modeler): update design mode section to include information about Documentation property

* docs(web-modeler): remove PII from screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaausley christinaausley christinaausley left review comments

@wollefitz wollefitz wollefitz approved these changes

Assignees

@nithinssabu nithinssabu

Labels
component:modeler Issues related with Modeler project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nithinssabu @christinaausley @wollefitz