Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert go module changes #3847

Merged
merged 7 commits into from
May 28, 2024
Merged

Revert go module changes #3847

merged 7 commits into from
May 28, 2024

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented May 27, 2024

Description

See related slack message https://camunda.slack.com/archives/C06HTSPD5AP/p1716792823991149

What did we learned:

  1. GitHub redirects help to still resolve old go modules
  2. old tags with old module names are still resolvable so this was no breaking change nor any impact to the customers
  3. On a new release, customers have to migrate to the new module name.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@Zelldon Zelldon requested a review from akeller May 27, 2024 07:43
Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a follow up Q on Slack re: 8.6, but let's handle that in a separate PR so we can get these changes merged and released ASAP.

@akeller akeller merged commit 80a95fa into main May 28, 2024
8 checks passed
@akeller akeller deleted the ck-revert-go-module-changes branch May 28, 2024 12:56
pepopowitz pushed a commit that referenced this pull request Oct 16, 2024
* refactor: simplify go client instructions

* fix: use correct go module name

* refactor: v1.3 simplify go client instructions

* fix: backport changes to v8.2

Backport changes from 06dd80c c5e8555

* fix: backport changes to v8.3

Backport changes from 06dd80c c5e8555

* fix: backport changes to v8.4

Backport changes from 06dd80c c5e8555

* fix: backport changes to v8.5

Backport changes from 06dd80c c5e8555
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants