-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(self-managed/console): describe tls config #4317
Conversation
👋 🤖 🤔 Hello, @christinaausley! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@christinaausley This is a last-minute feature we've implemented for console self-managed (for the 8.6 release). It will be tested hopefully next week, but it would be great if you could have a quick look into the description. Thanks! |
@urbanisierung Happy to have a look -- also adding @conceptualshark for some SM-focused review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two commits added here:
- I updated the URLs in the application-configs page. This should ensure they're all linking to the correct version of the docs.
- I organized some of this content into tables to make the steps/requirements a little clearer, but feel free to revert if you'd like me to update the content more as-is.
Hi, I might miss(understand) something, so apologies if question seems unnecessary: Just to clarify: is it correct that Console application consists of both frontend and backend and that both, front- and backend are served on the same host? And therefore only 1 certificate and 1 set of SSL options is required (other than web modeler, where frontend (webapp) and backend (restapi) run separately)? If yes, then this looks good to me 👍 (I didn't test it on a installation as of now though; could try to do that on friday if required, if there is a docker image available) |
@j-lindner exactly, that's how Console is working in SM. Frontend and Backend are served on the same host (basically the frontend app is served by the backend). |
@urbanisierung I added 8.6 labels to this, but please move it out of draft when you are ready. |
@akeller Unfortunately we found a dependency in the helm charts that need to be implemented, so the feature won't gonna make it into the 8.6 release :( |
Hi @urbanisierung -- just checking in. Is this still slated for the 8.7 release as of now? |
@christinaausley I hope so. One missing piece was implemented and we're waiting now for QA approval. |
@christinaausley We got green lights from QA. Can you please have a final look? Thanks! |
|
Description
Describes how to configure SSL for Console Self-Managed.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).