feat(dependencies): link to written offer #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
akeller
reviewed
Sep 24, 2024
MaxTru
force-pushed
the
dependencies-written-offer
branch
from
293e030
to
d181ad7
Compare
akeller
added
target:8.6
MaxTru
force-pushed
the
dependencies-written-offer
branch
from
bf570dc
to
9e7a6f2
Compare
9 tasks
mesellings
approved these changes
Oct 4, 2024
| @@ -1,90 +1,66 @@ | |||
| --- | |||
| id: dependencies | |||
| title: "Dependencies" | |||
| title: "Source-code and third-party dependencies" | |||
There was a problem hiding this comment.
Suggested change
| title: "Source-code and third-party dependencies" | |
| title: "Source code and third-party dependencies" |
Not sure the hyphen should be here?
| @@ -1,90 +1,66 @@ | |||
| --- | |||
| id: dependencies | |||
| title: "Dependencies" | |||
| title: "Source-code and third-party dependencies" | |||
| description: "Dependencies and Third Party Libraries for all the components of Camunda 8" | |||
There was a problem hiding this comment.
Suggested change
| description: "Dependencies and Third Party Libraries for all the components of Camunda 8" | |
| description: "Dependencies and third-party libraries for all Camunda 8 components." |
Suggestion: Consistent use of third-party and capitalisation, slight rewording for conciseness
| description: "Dependencies and Third Party Libraries for all the components of Camunda 8" | ||
| keywords: ["dependencies", "third party", "third party libraries"] | ||
| --- | ||
|
|
||
| A complete list of all dependencies and third-party libraries for all the components of Camunda 8 (including Self-Managed). | ||
| Camunda provides its users and customers access to its source code as part of [this written offer](https://legal.camunda.com/licensing-and-other-legal-terms#written-offer-source-code), as well as CycloneDX SBOMs, which list all direct and transitive third-party dependencies and their respective licenses. Please click the tabs below to access these items for each Camunda component. |
There was a problem hiding this comment.
Suggested change
| Camunda provides its users and customers access to its source code as part of [this written offer](https://legal.camunda.com/licensing-and-other-legal-terms#written-offer-source-code), as well as CycloneDX SBOMs, which list all direct and transitive third-party dependencies and their respective licenses. Please click the tabs below to access these items for each Camunda component. | |
| Camunda provides its users and customers with access to its source code as part of [this written offer](https://legal.camunda.com/licensing-and-other-legal-terms#written-offer-source-code), as well as CycloneDX SBOMs, which list all direct and transitive third-party dependencies and their respective licenses. Please click the tabs below to access these items for each Camunda component. |
Added "with"
|
@mesellings agree with your suggestion, but this was already merged 🙈 Can you please follow up and do these improvements in a separate PR? |
9 tasks
christinaausley
pushed a commit
that referenced
this pull request
Oct 7, 2024
* feat(dependencies): link to written offer * feat(dependencies): harmonize wording * Related to camunda/engineering-leadership-team#68 * closes camunda/engineering-leadership-team#68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When should this change go live?
holdlabel or convert to draft PR)PR Checklist
/versioned_docsdirectory./docsdirectory (aka/next/).