Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(sqs-inbound): add a note about the polling time #4389

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

mathias-vandaele
Copy link
Contributor

@mathias-vandaele mathias-vandaele commented Oct 3, 2024

Description

This is a modification concerning 8.6.0 version

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@mathias-vandaele mathias-vandaele added the 8.6.0 October 2024 minor release label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/components/connectors/out-of-the-box-connectors/amazon-sqs.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley added the component:connectors Issues related to the connectors project. label Oct 3, 2024
@christinaausley
Copy link
Contributor

Hi 👋 Just let us know when you are ready for final review from @camunda/tech-writers and an engineering review.

@mathias-vandaele
Copy link
Contributor Author

I am ready for final review @christinaausley

Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you. Approving, since I was requested for review. Please keep in mind, I am no longer with Connectors team, still with Camunda though :)

@akeller akeller requested a review from sbuettner October 7, 2024 15:10
@akeller akeller merged commit cd3e689 into main Oct 7, 2024
17 checks passed
@akeller akeller deleted the 929-update-sqs-docs-with-polling-interval-override branch October 7, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0 October 2024 minor release component:connectors Issues related to the connectors project.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants