Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comprehend doc #4391

Merged
merged 6 commits into from
Oct 8, 2024
Merged

docs: add comprehend doc #4391

merged 6 commits into from
Oct 8, 2024

Conversation

DenovVasil
Copy link
Contributor

@DenovVasil DenovVasil commented Oct 3, 2024

Description

add comprehend documentation for issue

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@DenovVasil DenovVasil self-assigned this Oct 3, 2024
@DenovVasil DenovVasil added the hold This issue is parked, do not merge. label Oct 3, 2024
Copy link
Contributor

github-actions bot commented Oct 3, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/components/connectors/out-of-the-box-connectors/amazon-comprehend.md
  • docs/components/connectors/out-of-the-box-connectors/available-connectors-overview.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@DenovVasil DenovVasil added 8.6.0 October 2024 minor release and removed hold This issue is parked, do not merge. labels Oct 3, 2024
@christinaausley christinaausley added the component:connectors Issues related to the connectors project. label Oct 3, 2024
@christinaausley
Copy link
Contributor

Hi @DenovVasil -- do you mind providing a link to the related issue? Just let us know when you are ready for final review from @camunda/tech-writers, and an engineering review.

@DenovVasil
Copy link
Contributor Author

DenovVasil commented Oct 4, 2024

Hi @DenovVasil -- do you mind providing a link to the related issue? Just let us know when you are ready for final review from @camunda/tech-writers, and an engineering review.

Hi, I added issue link to description
I will ask for your review after I receive approve from dev team.

@akeller
Copy link
Member

akeller commented Oct 7, 2024

@DenovVasil are you close to moving this out of draft so we can review and merge? We are prepping to cut the docs and you may need to backport these changes.

@DenovVasil DenovVasil marked this pull request as ready for review October 7, 2024 15:13
@akeller akeller requested review from sbuettner and a team October 7, 2024 15:24
@christinaausley christinaausley requested review from christinaausley and removed request for a team October 7, 2024 16:14
christinaausley
christinaausley previously approved these changes Oct 7, 2024
sbuettner
sbuettner previously approved these changes Oct 8, 2024
@christinaausley christinaausley dismissed stale reviews from sbuettner and themself via dc3c3d5 October 8, 2024 11:33
christinaausley
christinaausley previously approved these changes Oct 8, 2024
christinaausley
christinaausley previously approved these changes Oct 8, 2024
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have backported this for you @DenovVasil -- may we merge?

@christinaausley
Copy link
Contributor

Note that based on Slack conversation, @DenovVasil is making a few adjustments and planning to merge shortly.

@DenovVasil
Copy link
Contributor Author

Note that based on Slack conversation, @DenovVasil is making a few adjustments and planning to merge shortly.

I consulted with my team and we decided that version 8.6.0 is not correct it should be 8.7.0

@christinaausley
Copy link
Contributor

Note that based on Slack conversation, @DenovVasil is making a few adjustments and planning to merge shortly.

I consulted with my team and we decided that version 8.6.0 is not correct it should be 8.7.0

Should this go out with the 8.7 release then? If so, please update the labels. @DenovVasil

@DenovVasil DenovVasil added target:8.7 Issues included in the 8.7 release and removed 8.6.0 October 2024 minor release labels Oct 8, 2024
@christinaausley
Copy link
Contributor

After jumping on a call with @DenovVasil, this can be merged into next, but should be removed from 8.6. Updating this now, and preparing to merge.

@christinaausley christinaausley enabled auto-merge (squash) October 8, 2024 14:45
@christinaausley christinaausley merged commit 23a090b into main Oct 8, 2024
7 checks passed
@christinaausley christinaausley deleted the 2924-add-comprehend-doc branch October 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:connectors Issues related to the connectors project. target:8.7 Issues included in the 8.7 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants