Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding some clarifications for Optimize usage with OpenSearch #4430

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

grlimacan
Copy link
Contributor

Description

Adding some clarifications for Optimize usage with OpenSearch

closes https://github.com/camunda/camunda-optimize/issues/14043

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@grlimacan grlimacan self-assigned this Oct 8, 2024
@grlimacan grlimacan added component:optimize Issues related with Optimize project deploy Stand up a temporary docs site with this PR labels Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.6/reference/supported-environments.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@grlimacan grlimacan force-pushed the optimize-14043-additional-opensearch-docs branch 2 times, most recently from 4b53bc9 to 13c1a41 Compare October 8, 2024 12:03
@grlimacan grlimacan marked this pull request as draft October 8, 2024 12:04
@grlimacan grlimacan force-pushed the optimize-14043-additional-opensearch-docs branch 2 times, most recently from 1d81314 to 946fb0a Compare October 8, 2024 13:43
@github-actions github-actions bot temporarily deployed to camunda-docs October 8, 2024 14:05 Destroyed
Copy link
Contributor

@PHWaechtler PHWaechtler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion and the link that currently doesnt resolve properly in the preview env

docs/self-managed/setup/install.md Outdated Show resolved Hide resolved
versioned_docs/version-8.6/self-managed/setup/install.md Outdated Show resolved Hide resolved
@grlimacan grlimacan force-pushed the optimize-14043-additional-opensearch-docs branch from 946fb0a to 8f50961 Compare October 17, 2024 13:35
@github-actions github-actions bot temporarily deployed to camunda-docs October 17, 2024 13:54 Destroyed
@grlimacan grlimacan force-pushed the optimize-14043-additional-opensearch-docs branch from 8f50961 to 5c7fb5d Compare October 17, 2024 14:24
@grlimacan grlimacan marked this pull request as ready for review October 17, 2024 14:25
@github-actions github-actions bot temporarily deployed to camunda-docs October 17, 2024 14:51 Destroyed
@grlimacan
Copy link
Contributor Author

Hi @akeller and @PHWaechtler , I have fixed the broken links and implemented the suggestions. During the process I also found an unrelated typo on the system-configuration.md files, so I used the opportunity to make that correct as well. Please re-review

@akeller akeller requested a review from a team October 17, 2024 15:54
@github-actions github-actions bot temporarily deployed to camunda-docs October 17, 2024 19:34 Destroyed
@grlimacan grlimacan merged commit e40d2ae into main Oct 18, 2024
6 checks passed
@grlimacan grlimacan deleted the optimize-14043-additional-opensearch-docs branch October 18, 2024 07:52
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:optimize Issues related with Optimize project deploy Stand up a temporary docs site with this PR
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants