Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new spring sdk config in getting started guide #4439

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

megglos
Copy link
Contributor

@megglos megglos commented Oct 9, 2024

Description

Aligning the guide with new property naming. Generally the sdk is backwardscompatible with old properties but there was a bug on that regard camunda/camunda#23183 and while we are here it's worth already updating the guide to the new properties anyway.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thank you @megglos

Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍

@akeller akeller enabled auto-merge (squash) October 9, 2024 14:46
@akeller akeller merged commit 94aa005 into main Oct 9, 2024
9 checks passed
@akeller akeller deleted the meg-new-sdk-config-in-guide branch October 9, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants