Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistent usage of tenant id placeholder #4470

Merged
merged 4 commits into from
Oct 16, 2024
Merged

Conversation

jonathanlukas
Copy link
Contributor

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@jonathanlukas jonathanlukas self-assigned this Oct 16, 2024
Copy link
Contributor

github-actions bot commented Oct 16, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@conceptualshark conceptualshark added component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed component:identity Issues related with Identity project labels Oct 16, 2024
@conceptualshark
Copy link
Contributor

@jonathanlukas Is this ready for review? Would you like the contents ported to versions other than 8.6?

@jonathanlukas
Copy link
Contributor Author

@conceptualshark thank you for asking. This should be adjusted to next and probably older versions

@conceptualshark
Copy link
Contributor

@jonathanlukas I updated the use of tenant ID on the issuer line above, as well, to specify Microsoft Entra (and did some cleanup while in here). Let me know if this shouldn't be the case for any reason, and I can remove it - otherwise thank you for catching this! 👍

@jonathanlukas jonathanlukas merged commit 25928dd into main Oct 16, 2024
5 checks passed
@jonathanlukas jonathanlukas deleted the jonathanlukas-patch-1 branch October 16, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:identity Issues related with Identity project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants