Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust guides naming #4553

Merged
merged 3 commits into from
Nov 14, 2024
Merged

adjust guides naming #4553

merged 3 commits into from
Nov 14, 2024
+16 −16

Conversation

christinaausley
Copy link
Contributor

Description

Closes https://github.com/camunda/developer-experience/issues/253.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Will backport upon approval.

Sorry, something went wrong.

@christinaausley
adjust guides naming
Loading
Loading status checks…
9fe40b5
@christinaausley christinaausley added component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR labels Nov 1, 2024
@christinaausley christinaausley self-assigned this Nov 1, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley
Copy link
Contributor Author

@mesellings @conceptualshark I'm just playing around with ideas in this PR for effective Guides naming. Do you have any thoughts, suggestions, opinions?

@github-actions github-actions bot temporarily deployed to camunda-docs November 1, 2024 18:39 Destroyed
mesellings
mesellings previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these changes a lot - they make perfect sense - just one note about the Connectors naming, otherwise great work! 🚀

christinaausley and others added 2 commits November 5, 2024 00:35
@christinaausley @mesellings
Update docs/guides/configuring-out-of-the-box-connector.md
Loading
Loading status checks…
573bbdf 
Co-authored-by: Mark Sellings <mark.sellings@camunda.com>
@christinaausley
backport
Loading
Loading status checks…
a2124ab
@christinaausley christinaausley marked this pull request as ready for review November 5, 2024 07:39
@christinaausley
Copy link
Contributor Author

Thank you for the review @mesellings! Backported 👍

@github-actions github-actions bot temporarily deployed to camunda-docs November 5, 2024 07:57 Destroyed
mesellings
mesellings approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@mesellings mesellings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm 👍 🥇

akeller
akeller reviewed Nov 5, 2024
View reviewed changes
docs/guides/improve-processes-with-optimize.md
@@ -1,7 +1,7 @@
---
id: improve-processes-with-optimize
title: Improve processes with Optimize
sidebar_label: Improve processes with Optimize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking - wasn't "improve" a keyword associated with Optimize? Would you want to adjust the page title, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @RomanJRW @felix-mueller Do you have opinions here on keywords used with Optimize?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not from my side, I think its a PM question predominantly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this PR but following up in ask-optimize on preferred keywords 👍

@christinaausley christinaausley merged commit 13b8540 into main Nov 14, 2024
7 checks passed
@christinaausley christinaausley deleted the guides-renaming branch November 14, 2024 21:26
@github-actions GitHub Actions
Copy link
Contributor

🧹 Preview environment for this PR has been torn down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akeller akeller

@RomanJRW RomanJRW

@mesellings mesellings

Assignees

@christinaausley christinaausley

Labels
component:docs Documentation improvements, including new or updated content deploy Stand up a temporary docs site with this PR
Projects
Documentation Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@christinaausley @akeller @RomanJRW @mesellings