-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the REST config to the Ingress guides #4602
Conversation
👋 🤖 🤔 Hello, @conceptualshark! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me, and clarifies. Thank you!
@jessesimpson36 Would you be able to double-check the update here? Thanks! |
I'd like to see a member of the Zeebe team pulled in to review this, given the Zeebe REST API is actively being removed. @conceptualshark can you reach out on #ask-zeebe? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read the content and verified the referenced options. This all looks good to me.
8361dfd
@akeller @jessesimpson36 With the zeebe REST API officially out of the docs for /next, I've updated this PR to remove the reference and remove the config from 8.7. Do you mind double-checking for a final review? |
:::note | ||
**Operate, Tasklist, Optimize, Modeler, Connectors, Console:** The Ingress path value for each Component (`global.identity.auth.<component>.redirectUrl`) should match the `contextPath` for that Component. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:::note | |
**Operate, Tasklist, Optimize, Modeler, Connectors, Console:** The Ingress path value for each Component (`global.identity.auth.<component>.redirectUrl`) should match the `contextPath` for that Component. | |
::: | |
:::note | |
**Operate, Tasklist, Optimize, Modeler, Connectors, Console:** The Ingress path value for each component (`global.identity.auth.<component>.redirectUrl`) should match the `contextPath` for that component. | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus the other versions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ For the C8 REST API (v2), do we need to add a similar change? Basically, adding info on this page with a similar link to the ingress setup instructions?
Otherwise, the changes look consistently applied across the relevant versions.
@akeller I've updated the Camunda REST API page as described! I think this should be the last place where this info was located/unclear. 🤞 |
🧹 Preview environment for this PR has been torn down. |
Description
Relates to #4137
This addresses:
I've added these changes to the available documentation, back through 8.5 for the Ingress docs - prior to that the formatting changes.
I've added these options into /next assuming that if the /v1 APIs remain available, it will still be useful, and if they're removed, we can address removing it at the same time as any other updates, but let me know if this isn't the right call.
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).