Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local-kubernetes-cluster.md #4686

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

chahin-healthhelper
Copy link
Contributor

@chahin-healthhelper chahin-healthhelper commented Nov 30, 2024

Fix Port-forwarding section

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

Fix Port-forwarding section
@CLAassistant
Copy link

CLAassistant commented Nov 30, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chahin-healthhelper
❌ conceptualshark
You have signed the CLA already but the status is still pending? Let us recheck it.

@akeller
Copy link
Member

akeller commented Dec 2, 2024

@chahin-healthhelper, can you please sign the CLA? We'll need this to merge your PR if approved.

@akeller akeller added component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Dec 2, 2024
@akeller
Copy link
Member

akeller commented Dec 2, 2024

@conceptualshark can you follow up on this external contribution and backport in a separate PR if necessary? I wasn't able to quickly confirm this value.

Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this locally shows camunda-platform is the correct prefix - this can be merged once the CLA is signed. 👍

@akeller
Copy link
Member

akeller commented Dec 4, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@chahin-healthhelper please sign our CLA so we can merge your PR.

@chahin-healthhelper
Copy link
Contributor Author

@akeller & @conceptualshark - I apologize for the delay; it has been a busy month!
CLA signed.

@akeller akeller enabled auto-merge (squash) January 7, 2025 20:15
@akeller
Copy link
Member

akeller commented Jan 7, 2025

@conceptualshark I've set this to auto-merge, but can you follow up with a PR for /next/ docs (if applicable)?

@akeller akeller merged commit ad7cf92 into camunda:main Jan 7, 2025
4 of 6 checks passed
@akeller
Copy link
Member

akeller commented Jan 7, 2025

Thank you @chahin-healthhelper!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants