-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(aws-s3): add documentation for the new aws s3 connector #4746
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @mathias-vandaele! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
axiosRef.defaults.headers[ | ||
"Authorization" | ||
] = `Bearer ${credentials.access_token}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[prettier] reported by reviewdog 🐶
axiosRef.defaults.headers[ | |
"Authorization" | |
] = `Bearer ${credentials.access_token}`; | |
axiosRef.defaults.headers["Authorization"] = | |
`Bearer ${credentials.access_token}`; |
axiosRef.defaults.headers[ | ||
"Authorization" | ||
] = `Bearer ${credentials.access_token}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[prettier] reported by reviewdog 🐶
axiosRef.defaults.headers[ | |
"Authorization" | |
] = `Bearer ${credentials.access_token}`; | |
axiosRef.defaults.headers["Authorization"] = | |
`Bearer ${credentials.access_token}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathias-vandaele Is this Prettier suggestion okay to commit - looks ok, but want to check 👍
axiosRef.defaults.headers[ | ||
"Authorization" | ||
] = `Bearer ${credentials.access_token}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[prettier] reported by reviewdog 🐶
axiosRef.defaults.headers[ | |
"Authorization" | |
] = `Bearer ${credentials.access_token}`; | |
axiosRef.defaults.headers["Authorization"] = | |
`Bearer ${credentials.access_token}`; |
axiosRef.defaults.headers[ | ||
"Authorization" | ||
] = `Bearer ${credentials.access_token}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[prettier] reported by reviewdog 🐶
axiosRef.defaults.headers[ | |
"Authorization" | |
] = `Bearer ${credentials.access_token}`; | |
axiosRef.defaults.headers["Authorization"] = | |
`Bearer ${credentials.access_token}`; |
axiosRef.defaults.headers[ | ||
"Authorization" | ||
] = `Bearer ${credentials.access_token}`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[prettier] reported by reviewdog 🐶
axiosRef.defaults.headers[ | |
"Authorization" | |
] = `Bearer ${credentials.access_token}`; | |
axiosRef.defaults.headers["Authorization"] = | |
`Bearer ${credentials.access_token}`; |
@mathias-vandaele when does this need to be published please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathias-vandaele Approved 👍 (I committed my changes directly - just the random prettier code suggestions you can decide to include or not)
@mesellings made a few changes, let me know if everything is good, should be merged when next release is coming |
The preview environment relating to the commit 2e4461f has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-4746/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - one non-blocking suggestion 👍
| Parameter | Description | | ||
| :----------- | :----------------------------------------------------------------------------------------------------------------------------------------------- | | ||
| `AWS bucket` | The targeted AWS S3 bucket where the document should be uploaded. | | ||
| `AWS key` | (Optional) The key of the document that uniquely identifies the object in an Amazon S3 bucket. Will fallback to the document filename if not set | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `AWS key` | (Optional) The key of the document that uniquely identifies the object in an Amazon S3 bucket. Will fallback to the document filename if not set | | |
| `AWS key` | (Optional) The key of the document that uniquely identifies the object in an Amazon S3 bucket. Will fallback to the document filename if not set. | |
Description
This is the documentation of AWS S3 connector which will be release on
8.7.0-alpha 3
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).