Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example value for max-message-size #4792

Merged
merged 2 commits into from
Dec 23, 2024
Merged

Conversation

falko
Copy link
Member

@falko falko commented Dec 18, 2024

@npepinpe once told me to use zeebe.client.message.max-message-size=4194304, which sounds like the default value and seems to be in bytes. If we use a too small example value, users may think the value is in megabytes. Obviously, we could also just document the unit but even then 3 bytes is likely not a workable value.

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@npepinpe once told me to use `zeebe.client.message.max-message-size=4194304`, which sounds like the default value and seems to be in bytes. If we use a too small example value, users may think the value is in megabytes. Obviously, we could also just document the unit but even then 3 bytes is likely not a workable value.
Copy link
Contributor

github-actions bot commented Dec 18, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

npepinpe
npepinpe previously approved these changes Dec 19, 2024
@christinaausley christinaausley enabled auto-merge (squash) December 23, 2024 14:52
@christinaausley christinaausley merged commit 9f20060 into main Dec 23, 2024
8 checks passed
@christinaausley christinaausley deleted the falko-max-message-size branch December 23, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants