Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST endpoint to Concepts > Signal #4832

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Add REST endpoint to Concepts > Signal #4832

merged 4 commits into from
Jan 10, 2025

Conversation

akeller
Copy link
Member

@akeller akeller commented Jan 9, 2025

Description

Looking for something else in the docs and I noticed the C8 REST API endpoint should be on the signal page. I added it and reordered the list, with gRPC at the bottom.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added the component:docs Documentation improvements, including new or updated content label Jan 9, 2025
@akeller akeller requested review from tmetzke, pepopowitz and a team January 9, 2025 21:13
@akeller akeller self-assigned this Jan 9, 2025
@akeller akeller changed the title Update signals.md Add REST endpoint to Concepts > Signal Jan 9, 2025
tmetzke
tmetzke previously approved these changes Jan 10, 2025
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice catch, thanks for fixing it right away 🍪

Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@akeller akeller merged commit 2b744cc into main Jan 10, 2025
9 checks passed
@akeller akeller deleted the add-signal-rest branch January 10, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants