-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(rest-connector): add hint about breaking change in 8.6 #5137
base: main
Are you sure you want to change the base?
fix(rest-connector): add hint about breaking change in 8.6 #5137
Conversation
@ztefanie, can you link to an issue or support ticket for reviewers to have a complete picture? Was this really a breaking change or a bug fix that was addressed in a patch? |
Sure it is about this There is a discussion on going in the incident slack channel: #inc-support-26056-multiple-set-cookie-headers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaking change should also likely go into announcements.
👋 🤖 🤔 Hello, @ztefanie! Did you make your changes in all the right places? These files were changed only in versioned_docs/version-8.6/. You might want to duplicate these changes in docs/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
c0177e0
to
9d0c1f2
Compare
See related issue I did not document the "breaking change" in the last two lines of the table below, because i consider this a bug fix and not a breaking change.
|
The preview environment relating to the commit bb60a8c has successfully been deployed. You can access it at https://preview.docs.camunda.cloud/pr-5137/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
The behavior for grouping headers had a breaking change from 8.5 to 8.6. This is now documented.
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.