chore(client): rename tabHistory to navigationHistory

camunda · Nov 28, 2018 · a830a8d · a830a8d
1 parent 563904d
commit a830a8d
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 16 deletions.
diff --git a/client/src/app/App.js b/client/src/app/App.js
@@ -74,7 +74,7 @@ export class App extends Component {
     this.tabComponentCache = {};
 
     // TODO(nikku): make state
-    this.tabHistory = new History();
+    this.navigationHistory = new History();
 
     // TODO(nikku): make state
     this.closedTabs = new History();
@@ -147,9 +147,9 @@ export class App extends Component {
       return tabShown.promise;
     }
 
-    const tabHistory = this.tabHistory;
+    const navigationHistory = this.navigationHistory;
 
-    tabHistory.push(tab);
+    navigationHistory.push(tab);
 
     return this.setActiveTab(tab);
   }
@@ -170,9 +170,9 @@ export class App extends Component {
       return getNextTab(tabs, activeTab, direction);
     };
 
-    const tabHistory = this.tabHistory;
+    const navigationHistory = this.navigationHistory;
 
-    const nextActiveTab = tabHistory.navigate(direction, nextFn);
+    const nextActiveTab = navigationHistory.navigate(direction, nextFn);
 
     return this.setActiveTab(nextActiveTab);
   }
@@ -270,7 +270,7 @@ export class App extends Component {
     });
 
     // replace in navigation history
-    const navigationHistory = this.tabHistory;
+    const navigationHistory = this.navigationHistory;
     navigationHistory.replace(tab, updatedTab);
 
     return updatedTab;
@@ -288,7 +288,7 @@ export class App extends Component {
     }
 
     if (tab !== EMPTY_TAB) {
-      const navigationHistory = this.tabHistory;
+      const navigationHistory = this.navigationHistory;
 
       if (navigationHistory.get() !== tab) {
         navigationHistory.push(tab);
@@ -339,7 +339,7 @@ export class App extends Component {
     } = this.state;
 
     const {
-      tabHistory,
+      navigationHistory,
       closedTabs
     } = this;
 
@@ -351,7 +351,7 @@ export class App extends Component {
 
     const newTabs = tabs.filter(t => t !== tab);
 
-    tabHistory.purge(tab);
+    navigationHistory.purge(tab);
 
     if (!isNew(tab)) {
       closedTabs.push(tab);
@@ -363,7 +363,7 @@ export class App extends Component {
 
       // open previous tab, if it exists
       const nextActive = (
-        tabHistory.get() ||
+        navigationHistory.get() ||
         newTabs[tabIdx] ||
         newTabs[tabIdx - 1] ||
         EMPTY_TAB

diff --git a/client/src/app/__tests__/AppSpec.js b/client/src/app/__tests__/AppSpec.js
@@ -1040,11 +1040,11 @@ describe('<App>', function() {
         await app.triggerAction('close-all-tabs');
 
         // then
-        const tabHistory = app.tabHistory;
+        const navigationHistory = app.navigationHistory;
 
-        expect(tabHistory.elements).to.be.empty;
-        expect(tabHistory.idx).to.eql(-1);
-        expect(tabHistory.get()).not.to.exist;
+        expect(navigationHistory.elements).to.be.empty;
+        expect(navigationHistory.idx).to.eql(-1);
+        expect(navigationHistory.get()).not.to.exist;
       });
 
     });
@@ -1580,10 +1580,10 @@ describe('<App>', function() {
       const updatedTab = await app.updateTab(tab, newAttrs);
 
       const {
-        tabHistory
+        navigationHistory
       } = app;
 
-      const tabs = tabHistory.elements;
+      const tabs = navigationHistory.elements;
 
       // then
       expect(tabs).to.not.include(tab);