Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renderer crashes when switching from XML editor to DMN table editor #1023

Closed
barmac opened this issue Nov 21, 2018 · 7 comments
Closed

Renderer crashes when switching from XML editor to DMN table editor #1023

barmac opened this issue Nov 21, 2018 · 7 comments
Labels
bug Something isn't working DMN
Milestone
M26

Comments

@barmac
Copy link
Collaborator

barmac commented Nov 21, 2018

Describe the Bug

Renderer crashes when user switches from XML editor to DMN table editor. The console indicates that there is an infinite rerender loop (max depth of rerender exceeded).

Steps to Reproduce

Steps to reproduce the behavior:

  1. Open new DMN tab
  2. Open XML editor
  3. Open DMN table editor

crash

Logs:
crash.log

Expected Behavior

Show DMN table editor and do not crash.

Environment

  • OS: MacOS 10.14.1
  • Camunda Modeler Version: next@e725255
@barmac barmac added bug Something isn't working DMN labels Nov 21, 2018
@barmac
Copy link
Collaborator Author

barmac commented Nov 21, 2018

Confirmed on production version.

@barmac
Copy link
Collaborator Author

barmac commented Nov 21, 2018

It seems like the whole App component falls into this loop. Further investigation should reveal what actually causes the problem.

@nikku
Copy link
Member

nikku commented Nov 21, 2018 •
edited
Loading

Confirmed on production version.

You mean the released v2.x version?

@pinussilvestrus
Copy link
Contributor

I can reproduce it on next branch, but not inside the current production version (master).

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Nov 22, 2018 •
edited
Loading

Maybe this is related to this switching sheet bug? Need more investigation here.

@barmac
Copy link
Collaborator Author

barmac commented Nov 22, 2018

@nikku @pinussilvestrus
I meant the current next generated with npm run all

@nikku nikku added the ready Ready to be worked on label Nov 22, 2018
@philippfromme philippfromme mentioned this issue Nov 22, 2018
Closed
58 tasks
@nikku nikku added this to the M26 milestone Nov 23, 2018
This was referenced Nov 28, 2018
Merged
Closed
Closed
@nikku nikku added in progress Currently worked on and removed ready Ready to be worked on labels Dec 13, 2018
@nikku
Copy link
Member

nikku commented Jan 14, 2019

Closed via #1073.

@nikku nikku closed this as completed Jan 14, 2019
@ghost ghost removed the in progress Currently worked on label Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working DMN
Projects
None yet
Milestone
M26
Development

No branches or pull requests
3 participants
@nikku @pinussilvestrus @barmac