-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore file content changed #1005
Conversation
This comment has been minimized.
This comment has been minimized.
Bug detected: When on XML-tab and agreeing the reloading, the changes did not affect. That might be caused by Fixed with last commit. |
52bc5ae
to
9dda3bd
Compare
9dda3bd
to
adfb1e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to properly integrate the tab updating with the state management as sketched in 4335ce0.
Please update your implementation as discussed.
4335ce0
to
2b84dc7
Compare
Rebased on latest |
89ec40c
to
a830a8d
Compare
Updated the implementation to fit with the wanted state management handling. For this there is a new method called I also renamed the label of the Now there are a couple of things to do:
When the second task is done I will give this PR to review again. |
I think the replacing of old namespaces one of the things that currently do not properly integrate with tab updating. |
@philippfromme Indeed, this was also the first occurrence I was thinking about 👍 Another procedure would be the updating of an empty tab with the initial file contents in |
e36dde4
to
f74e679
Compare
e8f116d
to
4df85c0
Compare
@nikku all changes should be adressed now! |
- App.js#openEmptyFile - BpmnEditor#handleNamespace
4df85c0
to
856a33f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
App.js#tabHistory
->App.js#navigationHistory
Closes #970