Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): use correct type param to empty file dialog #1037

Merged
merged 1 commit into from
Nov 29, 2018
Merged

fix(client): use correct type param to empty file dialog #1037

merged 1 commit into from
Nov 29, 2018

Conversation

pinussilvestrus
Copy link
Contributor

  • fixes the throwed exception on open empty files
  • adds test for correct function call

Closes #1036

@ghost ghost assigned pinussilvestrus Nov 29, 2018
@ghost ghost added the needs review Review pending label Nov 29, 2018
@pinussilvestrus pinussilvestrus mentioned this pull request Nov 29, 2018
Merged
@pinussilvestrus pinussilvestrus force-pushed the 1036-fix-open-empty-file branch from cbc7919 to f3e7d26 Compare November 29, 2018 07:36
nikku
nikku approved these changes Nov 29, 2018
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@merge-me merge-me bot merged commit f932753 into next Nov 29, 2018
@ghost ghost removed the needs review Review pending label Nov 29, 2018
@delete-merged-branch delete-merged-branch bot deleted the 1036-fix-open-empty-file branch November 29, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees

@pinussilvestrus pinussilvestrus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinussilvestrus @nikku