Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CTRL+A not working in diagram editors #1027

Closed
1 task done
nikku opened this issue Nov 22, 2018 · 3 comments
Closed
1 task done

CTRL+A not working in diagram editors #1027

nikku opened this issue Nov 22, 2018 · 3 comments
Assignees
@nikku @philippfromme
Labels
bug Something isn't working platform:Linux refactoring
Milestone
M26

Comments

@nikku
Copy link
Member

nikku commented Nov 22, 2018 •
edited by philippfromme
Loading

Steps to Reproduce

  • Open BPMN diagram
  • CTRL+A to select all elements
  • Does not work...

Tasks

  • Restore ShortcutsFix to support key binding for built-in key strokes on Windows and Linux
@nikku nikku added this to the M25 milestone Nov 22, 2018
@nikku nikku added bug Something isn't working ready Ready to be worked on refactoring labels Nov 22, 2018
@nikku

This comment has been minimized.

Sign in to view
@nikku

This comment has been minimized.

Sign in to view
@philippfromme philippfromme mentioned this issue Nov 23, 2018
Closed
58 tasks
@nikku nikku modified the milestones: M25, M26 Nov 23, 2018
@philippfromme
Copy link
Contributor

Some more information:

  • some keyboard events (copy, cut, paste, selectAll, ...) are hard-coded in Chrom*
  • only workaround in order to have custom handling is window.addEventListener

Related issues:

electron/electron#7165

@ghost ghost assigned philippfromme Nov 27, 2018
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Nov 27, 2018
philippfromme added a commit that referenced this issue Nov 29, 2018
@philippfromme
feat(client): introduce role property for copy, paste and selectAll
03e6906 
Related to #1027
philippfromme added a commit that referenced this issue Nov 29, 2018
@philippfromme
feat(client): add diagram-related keyboard bindings
1271236 
* properly integrate with command stack when working with properties panel
* handle menu accelerators that can't be overridden on Windows/Linux

Closes #1027
philippfromme added a commit that referenced this issue Nov 29, 2018
@philippfromme
feat(client): make menu entries work in all cases
d770f51 
* clicking menu entry will trigger editor action or default behavior in
the cases of copy, paste and selectAll depending on an input being
focussed or not

Related to #1027
philippfromme added a commit that referenced this issue Nov 29, 2018
@philippfromme
feat(client): add diagram-related keyboard bindings
4b3ab1d 
* properly integrate with command stack when working with properties panel
* handle menu accelerators that can't be overridden on Windows/Linux

Closes #1027
@philippfromme philippfromme added needs review Review pending and removed in progress Currently worked on labels Nov 29, 2018
@nikku nikku mentioned this issue Nov 29, 2018
Merged
@ghost ghost assigned nikku Nov 29, 2018
nikku pushed a commit that referenced this issue Nov 30, 2018
@philippfromme @nikku
feat(client): make menu entries work in all cases
5aaf84d 
* clicking menu entry will trigger editor action or default behavior in
the cases of copy, paste and selectAll depending on an input being
focussed or not

Related to #1027
nikku pushed a commit that referenced this issue Nov 30, 2018
@philippfromme @nikku
feat(client): add diagram-related keyboard bindings
59712d2 
* properly integrate with command stack when working with properties panel
* handle menu accelerators that can't be overridden on Windows/Linux

Closes #1027
nikku pushed a commit that referenced this issue Dec 3, 2018
@philippfromme @nikku
feat(client): make menu entries work in all cases
09abf3f 
* clicking menu entry will trigger editor action or default behavior in
the cases of copy, paste and selectAll depending on an input being
focussed or not

Related to #1027
nikku pushed a commit that referenced this issue Dec 3, 2018
@philippfromme @nikku
feat(client): add diagram-related keyboard bindings
0878fdf 
* properly integrate with command stack when working with properties panel
* handle menu accelerators that can't be overridden on Windows/Linux

Closes #1027
philippfromme added a commit that referenced this issue Dec 4, 2018
@philippfromme
feat(client): make menu entries work in all cases
d9208c3 
* clicking menu entry will trigger editor action or default behavior in
the cases of copy, paste and selectAll depending on an input being
focussed or not

Related to #1027
philippfromme added a commit that referenced this issue Dec 4, 2018
@philippfromme
feat(client): add diagram-related keyboard bindings
3cdc8fb 
* properly integrate with command stack when working with properties panel
* handle menu accelerators that can't be overridden on Windows/Linux

Closes #1027
philippfromme added a commit that referenced this issue Dec 5, 2018
@philippfromme
fix(client): fix menu entries
eb00bc0 
* allow role property
* add copy, paste and select all entries to CMMN and DMN editor
* properly enable and disable entries

Closes #1027
philippfromme added a commit that referenced this issue Dec 5, 2018
@philippfromme
fix(client): fix menu entries
a138ceb 
* allow role property
* add copy, paste and select all entries to CMMN and DMN editor
* properly enable and disable entries

Closes #1027
philippfromme added a commit that referenced this issue Dec 5, 2018
@philippfromme
fix(client): fix menu entries
59b526a 
* allow role property
* add copy, paste and select all entries to CMMN and DMN editor
* properly enable and disable entries

Closes #1027
philippfromme added a commit that referenced this issue Dec 5, 2018
@philippfromme
fix(client): fix menu entries
f6b6878 
* allow role property in menu entries
* distinct between default and custom copy, cut and paste menu entries
* add copy, cut, paste and select all entries to CMMN and DMN editor
* properly enable and disable entries

Closes #1027
nikku pushed a commit that referenced this issue Dec 5, 2018
@philippfromme @nikku
fix(client): fix menu entries
e9142b5 
* allow role property in menu entries
* distinct between default and custom copy, cut and paste menu entries
* add copy, cut, paste and select all entries to CMMN and DMN editor
* properly enable and disable entries

Closes #1027
@ghost ghost removed the needs review Review pending label Dec 5, 2018
@nikku nikku mentioned this issue Dec 10, 2018
Closed
barmac pushed a commit that referenced this issue Jan 17, 2019
@philippfromme @barmac
fix(client): fix menu entries
bfc028f 
* allow role property in menu entries
* distinct between default and custom copy, cut and paste menu entries
* add copy, cut, paste and select all entries to CMMN and DMN editor
* properly enable and disable entries

Closes #1027
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

@philippfromme philippfromme

Labels
bug Something isn't working platform:Linux refactoring
Projects
None yet
Milestone
M26
Development

No branches or pull requests
2 participants
@nikku @philippfromme