Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate CommandStack#undo and CommandStack#redo when working with the properties panel #1059

Closed
philippfromme opened this issue Dec 5, 2018 · 1 comment
Closed

Integrate CommandStack#undo and CommandStack#redo when working with the properties panel #1059

philippfromme opened this issue Dec 5, 2018 · 1 comment
Assignees
@philippfromme
Labels
enhancement New feature or request
Milestone
M26

Comments

@philippfromme
Copy link
Contributor

Integrating CommandStack#undo and CommandStack#redo when working with the properties panel was previously implemented in ShortcutsFix. This fix was initially implemented to work around issues with overriding default keyboard bindings on Linux and Windows which is a different issue. The fix has since been re-implemented. This particular behavior should be implemented in a different place.
@philippfromme philippfromme changed the title Integrate properties panel with command stack Integrate CommandStack#undo and CommandStack#redo when working with the properties panel Dec 5, 2018
This was referenced Dec 5, 2018
Closed
Merged
@pinussilvestrus pinussilvestrus added enhancement New feature or request backlog Queued in backlog labels Dec 12, 2018
@nikku nikku added ready Ready to be worked on and removed backlog Queued in backlog labels Dec 13, 2018
@nikku nikku added this to the M26 milestone Dec 19, 2018
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Jan 14, 2019
@philippfromme philippfromme self-assigned this Jan 14, 2019
philippfromme added a commit that referenced this issue Jan 15, 2019
@philippfromme
feat(client): integrate properties panel inputs with command stack
8c24af6 
* trigger command stack undo/ redo instead of native

Closes #1059
philippfromme added a commit that referenced this issue Jan 15, 2019
@philippfromme
feat(client): integrate properties panel inputs with command stack
64ca1d2 
* trigger command stack undo/ redo instead of native

Closes #1059
@philippfromme philippfromme mentioned this issue Jan 15, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 15, 2019
philippfromme added a commit that referenced this issue Jan 15, 2019
@philippfromme
feat(client): add properties panel keyboard bindings
ca29195 
* handle undo/redo/selectAll

Closes #1059
philippfromme added a commit that referenced this issue Jan 15, 2019
@philippfromme
feat(client): add properties panel keyboard bindings
2068e30 
* handle undo/redo/selectAll

Closes #1059
merge-me bot pushed a commit that referenced this issue Jan 16, 2019
@philippfromme @merge-me
feat(client): add properties panel keyboard bindings
1e5174b 
* handle undo/redo/selectAll

Closes #1059
@barmac
Copy link
Collaborator

barmac commented Jan 16, 2019

Closed via #1101

@barmac barmac closed this as completed Jan 16, 2019
@ghost ghost removed the needs review Review pending label Jan 16, 2019
barmac pushed a commit that referenced this issue Jan 17, 2019
@philippfromme @barmac
feat(client): add properties panel keyboard bindings
7fc4c81 
* handle undo/redo/selectAll

Closes #1059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
enhancement New feature or request
Projects
None yet
Milestone
M26
Development

No branches or pull requests
4 participants
@nikku @philippfromme @pinussilvestrus @barmac