Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to DMN diagram removes Edit menu #1097

Closed
nikku opened this issue Jan 15, 2019 · 4 comments
Closed

Switching to DMN diagram removes Edit menu #1097

nikku opened this issue Jan 15, 2019 · 4 comments
Assignees
@barmac
Labels
bug Something isn't working
Milestone
M26

Comments

@nikku
Copy link
Member

nikku commented Jan 15, 2019

Describe the Bug

The Edit menu hides when switching to the DMN tab.

Steps to Reproduce

Steps to reproduce the behavior:

  • Open BPMN Tab
  • Open DMN Tab
  • Switch BPMN -> DMN tab
  • See the Edit menu vanishing

Expected Behavior

Edit menu stays available.

Environment

Please complete the following information:

  • OS: Linux, Windows, ...
  • Camunda Modeler Version: next
@nikku nikku added bug Something isn't working ready Ready to be worked on labels Jan 15, 2019
@nikku nikku added this to the M26 milestone Jan 15, 2019
@philippfromme philippfromme mentioned this issue Jan 15, 2019
Closed
58 tasks
@barmac
Copy link
Collaborator

barmac commented Jan 15, 2019

I can reproduce this.

@ghost ghost assigned barmac Jan 15, 2019
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Jan 15, 2019
@barmac
Copy link
Collaborator

barmac commented Jan 16, 2019

Dmn-js Manager does not fire attach event in attachTo method which is not the case in Viewers of bpmn-js or cmmn-js.

@barmac
Copy link
Collaborator

barmac commented Jan 16, 2019

Fixed in bpmn-io/dmn-js#386. As soon as I update the libraries it should be all right.

barmac added a commit that referenced this issue Jan 16, 2019
@barmac
chore(client): update dmn-js and diagram-js
ee33b50 
Closes #1097
@barmac barmac mentioned this issue Jan 16, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 16, 2019
merge-me bot pushed a commit that referenced this issue Jan 16, 2019
@barmac @merge-me
chore(client): update dmn-js and diagram-js
7af6543 
Closes #1097
@barmac
Copy link
Collaborator

barmac commented Jan 16, 2019

Closed via #1110

@barmac barmac closed this as completed Jan 16, 2019
@ghost ghost removed the needs review Review pending label Jan 16, 2019
barmac added a commit that referenced this issue Jan 17, 2019
@barmac
chore(client): update dmn-js and diagram-js
2b7337a 
Closes #1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working
Projects
None yet
Milestone
M26
Development

No branches or pull requests
2 participants
@nikku @barmac