Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error when trying to export diagram as a jpg file #1103

Closed
barmac opened this issue Jan 15, 2019 · 2 comments
Closed

Error when trying to export diagram as a jpg file #1103

barmac opened this issue Jan 15, 2019 · 2 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@barmac
Copy link
Collaborator

barmac commented Jan 15, 2019

Describe the Bug

I can't export diagram as a jpg file. It happens on MacOS as well as on Linux.

Steps to Reproduce

extensions

Expected Behavior

A jpg file is saved.

Environment

  • OS: MacOS 10.14.2
  • Camunda Modeler Version: next
@barmac barmac added bug Something isn't working ready Ready to be worked on labels Jan 15, 2019
@philippfromme
Copy link
Contributor

Hint: Change jpg to jpeg.

// generateImage.js

// list of defined encodings
const ENCODINGS = ['image/png', 'image/jpeg'];

function generateImage(type, svg) {
  const encoding = 'image/' + type;

  let context, canvas;

  if (ENCODINGS.indexOf(encoding) === -1) {
    throw new Error('<' + type + '> is an unknown type for converting svg to image');
  }

// ...

@philippfromme philippfromme self-assigned this Jan 16, 2019
@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Jan 16, 2019
philippfromme added a commit that referenced this issue Jan 16, 2019
* change jpg to jpeg
* remove point from extensions

Closes #1102
Closes #1103
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 16, 2019
philippfromme added a commit that referenced this issue Jan 16, 2019
* change jpg to jpeg
* remove point from extensions

Closes #1102
Closes #1103
philippfromme added a commit that referenced this issue Jan 16, 2019
* change jpg to jpeg
* remove point from extensions

Closes #1102
Closes #1103
nikku pushed a commit that referenced this issue Jan 16, 2019
* change jpg to jpeg
* remove point from extensions

Closes #1102
Closes #1103
merge-me bot pushed a commit that referenced this issue Jan 16, 2019
* change jpg to jpeg
* remove point from extensions

Closes #1102
Closes #1103
@barmac
Copy link
Collaborator Author

barmac commented Jan 16, 2019

Closed via #1106

@barmac barmac closed this as completed Jan 16, 2019
@ghost ghost removed the needs review Review pending label Jan 16, 2019
@nikku nikku added this to the M26 milestone Jan 16, 2019
barmac pushed a commit that referenced this issue Jan 17, 2019
* change jpg to jpeg
* remove point from extensions

Closes #1102
Closes #1103
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants