Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Listen for propertiesPanel.focusin and propertiesPanel.focusout in CMMN and DMN editor #1105

Closed
philippfromme opened this issue Jan 16, 2019 · 1 comment
Closed

Listen for propertiesPanel.focusin and propertiesPanel.focusout in CMMN and DMN editor #1105

philippfromme opened this issue Jan 16, 2019 · 1 comment
Assignees
@philippfromme
Milestone
M26

Comments

@philippfromme
Copy link
Contributor

I simply forgot to listen for propertiesPanel.focusin and propertiesPanel.focusout the in CMMN and DMN editor in order to update the edit menu.
@philippfromme philippfromme self-assigned this Jan 16, 2019
This was referenced Jan 16, 2019
Merged
Closed
philippfromme added a commit that referenced this issue Jan 16, 2019
@philippfromme
fix(client): listen for properties panel focus events
9aeb4b9 
* listen for focusin and focusout
* add tests to verify editor is listening for specific events

Closes #1105
@ghost ghost added the in progress Currently worked on label Jan 16, 2019
philippfromme added a commit that referenced this issue Jan 16, 2019
@philippfromme
fix(client): listen for properties panel focus events
d1cb456 
* listen for focusin and focusout
* add tests to verify editor is listening for specific events

Closes #1105
@philippfromme philippfromme mentioned this issue Jan 16, 2019
Merged
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Jan 16, 2019
merge-me bot pushed a commit that referenced this issue Jan 16, 2019
@philippfromme @merge-me
fix(client): listen for properties panel focus events
58acc29 
* listen for focusin and focusout
* add tests to verify editor is listening for specific events

Closes #1105
@barmac
Copy link
Collaborator

barmac commented Jan 16, 2019

Closed via #1109

@barmac barmac closed this as completed Jan 16, 2019
@ghost ghost removed the needs review Review pending label Jan 16, 2019
@barmac barmac added this to the M26 milestone Jan 16, 2019
barmac pushed a commit that referenced this issue Jan 17, 2019
@philippfromme @barmac
fix(client): listen for properties panel focus events
e3e756a 
* listen for focusin and focusout
* add tests to verify editor is listening for specific events

Closes #1105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
M26
Development

No branches or pull requests
2 participants
@philippfromme @barmac