Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wire save actions #894

Closed
5 tasks
nikku opened this issue Aug 23, 2018 · 1 comment
Closed
5 tasks

Wire save actions #894

nikku opened this issue Aug 23, 2018 · 1 comment
Labels
refactoring
Milestone
M26

Comments

@nikku
Copy link
Member

nikku commented Aug 23, 2018 •
edited
Loading

Todo

  • save file
  • save all files (dirty only)
  • ask for save on close
  • add to tab history if dirty only
  • show before save
@nikku nikku added in progress Currently worked on refactoring labels Aug 23, 2018
@philippfromme philippfromme mentioned this issue Aug 23, 2018
Closed
58 tasks
nikku added a commit that referenced this issue Aug 23, 2018
@nikku
feat(client): save actions + tab state management
cb9db12 
* tab is shown before asking to save
* tab contents are retrieved before save

Related to #894
nikku added a commit that referenced this issue Aug 23, 2018
@nikku
feat(client): save actions + tab state management
e255c1a 
* consistent dirty state is shown and managed outside tab
* tab is shown before asking to save
* tab contents are retrieved before save

Related to #894
nikku added a commit that referenced this issue Aug 23, 2018
@nikku
feat(client): add save using backend
f186f96 
Related to #894
nikku added a commit that referenced this issue Aug 23, 2018
@nikku
feat(client): complete integrating save options
8c4d71c 
Closes #894
@nikku
Copy link
Member Author

nikku commented Aug 23, 2018

Closed via 8c4d71c.

@nikku nikku closed this as completed Aug 23, 2018
@ghost ghost removed the in progress Currently worked on label Aug 23, 2018
nikku added a commit that referenced this issue Aug 24, 2018
@nikku
fix(client): only add tabs for existing files to file open history
2083c5f 
Related to #894
nikku added a commit that referenced this issue Aug 24, 2018
@nikku
feat(client): save actions + tab state management
3d3d24b 
* consistent dirty state is shown and managed outside tab
* tab is shown before asking to save
* tab contents are retrieved before save

Related to #894
nikku added a commit that referenced this issue Aug 24, 2018
@nikku
feat(client): add save using backend
d7772aa 
Related to #894
nikku added a commit that referenced this issue Aug 24, 2018
@nikku
feat(client): complete integrating save options
14f2cce 
Closes #894
nikku added a commit that referenced this issue Aug 24, 2018
@nikku
fix(client): only add tabs for existing files to file open history
be66be6 
Related to #894
nikku added a commit that referenced this issue Sep 24, 2018
@nikku
feat(client): save actions + tab state management
12f7ff4 
* consistent dirty state is shown and managed outside tab
* tab is shown before asking to save
* tab contents are retrieved before save

Related to #894
nikku added a commit that referenced this issue Sep 24, 2018
@nikku
feat(client): add save using backend
8ac2e78 
Related to #894
nikku added a commit that referenced this issue Sep 24, 2018
@nikku
feat(client): complete integrating save options
4098188 
Closes #894
nikku added a commit that referenced this issue Sep 24, 2018
@nikku
fix(client): only add tabs for existing files to file open history
c2187d3 
Related to #894
@nikku nikku added this to the M26 milestone Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
M26
Development

No branches or pull requests
1 participant
@nikku