Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor application menu #967

Closed
5 tasks
philippfromme opened this issue Oct 31, 2018 · 0 comments
Closed
5 tasks

Refactor application menu #967

philippfromme opened this issue Oct 31, 2018 · 0 comments
Assignees
@barmac
Milestone
M26

Comments

@philippfromme
Copy link
Contributor

philippfromme commented Oct 31, 2018 •
edited
Loading

Right now the application menu contains a lot of hard coded entries that should be configured through the client instead.

Todo:
@philippfromme philippfromme mentioned this issue Oct 31, 2018
Closed
58 tasks
@philippfromme philippfromme added the ready Ready to be worked on label Nov 6, 2018
@ghost ghost assigned barmac Nov 8, 2018
@ghost ghost added in progress Currently worked on and removed ready Ready to be worked on labels Nov 8, 2018
barmac added a commit that referenced this issue Nov 15, 2018
@barmac
feat(app/menu): add proper state check to switch tabs
45404c8 
Closes #967
@barmac barmac mentioned this issue Nov 15, 2018
Closed
@ghost ghost added needs review Review pending and removed in progress Currently worked on labels Nov 15, 2018
barmac added a commit that referenced this issue Nov 15, 2018
@barmac
feat(app/menu): add proper state check to switch tabs
cd84abe 
Closes #967
barmac added a commit that referenced this issue Nov 15, 2018
@barmac
feat(app/menu): refactor menu
a54dd4c 
+ the menus for file, help and context menu  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
barmac added a commit that referenced this issue Nov 15, 2018
@barmac
feat(app/menu): refactor menu
28b26ce 
+ the menus for file, help and context menu  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
barmac added a commit that referenced this issue Nov 16, 2018
@barmac
feat(app/menu): refactor menu
c3403b1 
+ the menus for file, help and context menu  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
barmac added a commit that referenced this issue Nov 16, 2018
@barmac
feat(app/menu): refactor menu
f75ffec 
+ the menus for file, help and context menu  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
barmac added a commit that referenced this issue Nov 16, 2018
@barmac
feat(app/menu): refactor menu
a7e5709 
+ the file and help menus  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
nikku pushed a commit that referenced this issue Nov 22, 2018
@barmac @nikku
feat(app/menu): refactor menu
bedafe9 
+ the file and help menus  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
barmac added a commit that referenced this issue Nov 22, 2018
@barmac
feat(app/menu): refactor menu
b892b2d 
+ the file and help menus  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
@nikku nikku closed this as completed in b848322 Nov 22, 2018
@ghost ghost removed the needs review Review pending label Nov 22, 2018
@nikku nikku added this to the M26 milestone Nov 23, 2018
nikku pushed a commit that referenced this issue Dec 1, 2018
@barmac @nikku
feat(app/menu): refactor menu
d0a81a2 
+ the file and help menus  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
barmac added a commit that referenced this issue Jan 17, 2019
@barmac
feat(app/menu): refactor menu
e1d86a6 
+ the file and help menus  will be registered
  at app startup
+ data for menus is provided by tab provider
+ window menu will be configurable from editor level
+ a proper state check will be run to switch tabs

Closes #967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
M26
Development

No branches or pull requests
3 participants
@nikku @philippfromme @barmac