Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make editor responsive #1084

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Make editor responsive #1084

merged 2 commits into from
Jan 11, 2019

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Dec 20, 2018 •
edited
Loading

This PR adds window resize listener to resize active editor along with the window.

Closes #1082

@ghost ghost assigned barmac Dec 20, 2018
@ghost ghost added the needs review Review pending label Dec 20, 2018
@barmac barmac force-pushed the 1082-make-editor-responsive branch from 4af872b to 5a85ce2 Compare December 20, 2018 09:14
@barmac barmac force-pushed the 1082-make-editor-responsive branch 2 times, most recently from af7fd6f to 131d741 Compare January 9, 2019 10:18
@barmac barmac changed the title WIP Make editor responsive Make editor responsive Jan 9, 2019
@barmac barmac force-pushed the 1082-make-editor-responsive branch 2 times, most recently from 3c4f1d4 to 6ac6540 Compare January 9, 2019 10:59
@barmac barmac requested a review from philippfromme January 9, 2019 11:47
@barmac barmac force-pushed the 1082-make-editor-responsive branch from 6ac6540 to 29ea757 Compare January 9, 2019 11:50
@barmac barmac mentioned this pull request Jan 9, 2019
Merged
@nikku nikku self-requested a review January 11, 2019 07:46
nikku
nikku approved these changes Jan 11, 2019
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@merge-me merge-me bot merged commit 8cd1af8 into next Jan 11, 2019
@delete-merged-branch delete-merged-branch bot deleted the 1082-make-editor-responsive branch January 11, 2019 08:35
@ghost ghost removed the needs review Review pending label Jan 11, 2019
@nikku nikku mentioned this pull request Jan 11, 2019
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

@philippfromme philippfromme Awaiting requested review from philippfromme

Assignees

@barmac barmac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barmac @nikku