Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore log component #935

Merged
merged 10 commits into from
Oct 4, 2018
Merged

Restore log component #935

merged 10 commits into from
Oct 4, 2018

Conversation

philippfromme
Copy link
Contributor

Closes #931.

@ghost ghost assigned philippfromme Oct 4, 2018
@ghost ghost added the needs review Review pending label Oct 4, 2018
@nikku nikku self-requested a review October 4, 2018 13:44
nikku and others added 10 commits October 4, 2018 15:46
@nikku
chore(client): use draggable boolean attribute without value
2fd79e1
@nikku
fix(client/dragger): drop initial broken drag coordinate
078282d
@nikku
feat(client): re-introduce log component
6c31e25 
Implemented functions

* log can be toggled via button
* log can be copied / cleared
* log data and toggle state is managed via app
* log focuses last element added
* log can be resized

Closes #931
@nikku
test(client): increate image export test time out
de8c088 
* this should address a timeout issue when running
  our test cases against the AppVeyor CI
@philippfromme @nikku
fix(client/log): position controls using CSS only
0f3fe75 
Related to #931
@philippfromme @nikku
chore(client/app): remove demo code
64e7dfb 
Related to #931
@philippfromme @nikku
fix(client/codemirror): fix font size
17cf17c 
Related to #931
@philippfromme @nikku
fix(client/tabbed): position bottom tab links absolutely
bdfdbf0 
Related to #931
@nikku
chore(project): don't lint coverage folder
a55c008
@nikku
test(client/Log): freeze current behavior *GG*
504e064
@ghost ghost assigned nikku Oct 4, 2018
nikku
nikku approved these changes Oct 4, 2018
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOOKING GOOD 🚀

@nikku nikku merged commit ec50317 into next Oct 4, 2018
@delete-merged-branch delete-merged-branch bot deleted the 931-log branch October 4, 2018 14:09
@ghost ghost removed the needs review Review pending label Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku approved these changes

Assignees

@nikku nikku

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku