Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web-modeler): remove unnecessary environment variables #1726

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

wollefitz
Copy link
Member

@wollefitz wollefitz commented May 2, 2024

Which problem does the PR fix?

Removes unnecessary environment variables after switching the underlying websockets library, see https://github.com/camunda/cawemo-laravel-websockets/issues/375

Merge only after Web Modeler's 8.6.0-alpha2/8.5.2/8.4.6/ 8.3.8/8.2.15 releases.

What's in this PR?

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid force-pushed the main branch 7 times, most recently from f0da3dc to c374f10 Compare June 6, 2024 14:29
@wollefitz wollefitz force-pushed the websockets-375-remove-pusher-cluster branch from 9c57fc4 to ac21a26 Compare June 6, 2024 18:20
@wollefitz wollefitz marked this pull request as ready for review June 6, 2024 18:20
@wollefitz wollefitz requested a review from a team June 6, 2024 18:31
@jfriedenstab jfriedenstab force-pushed the websockets-375-remove-pusher-cluster branch from ac21a26 to 2187613 Compare June 13, 2024 17:50
@jfriedenstab jfriedenstab merged commit 85df4e7 into main Jun 13, 2024
32 checks passed
@jfriedenstab jfriedenstab deleted the websockets-375-remove-pusher-cluster branch June 13, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants