Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(workflows): use directory-based structure #1988

Merged
merged 3 commits into from
Jun 12, 2024
Merged

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Jun 12, 2024

Which problem does the PR fix?

Task: https://github.com/camunda/distribution/issues/265

What's in this PR?

Misc fixes.

Checklist

Please make sure to follow our Contributing Guide.

Before opening the PR:

  • In the repo's root dir, run make go.update-golden-only.
  • There is no other open pull request for the same update/change.
  • Tests for charts are added (if needed).
  • In-repo documentation are updated (if needed).

After opening the PR:

  • Did you sign our CLA (Contributor License Agreement)? It will show once you open the PR.
  • Did all checks/tests pass in the PR?

@aabouzaid aabouzaid self-assigned this Jun 12, 2024
@aabouzaid aabouzaid force-pushed the 265-aa-follow-up branch 6 times, most recently from 387e2cb to 8e8faba Compare June 12, 2024 17:17
Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
@aabouzaid aabouzaid marked this pull request as ready for review June 12, 2024 22:07
@aabouzaid aabouzaid merged commit 85d2ddb into main Jun 12, 2024
7 checks passed
@aabouzaid aabouzaid deleted the 265-aa-follow-up branch June 12, 2024 22:08
@aabouzaid aabouzaid changed the title chore(follow-up): use directory-based structure ci(workflows): use directory-based structure Jun 12, 2024
aabouzaid added a commit that referenced this pull request Jul 13, 2024
* simplify getting the previous chart version in workflow-vars

* update working dir in chart-release-snapshot.yaml

* use unit test template

---------

Signed-off-by: Ahmed AbouZaid <6760103+aabouzaid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant