refactor(engine): split duplicate check method

* split method of DRG duplicate check to be more explicit and align with the new check method for decisions
camunda · May 31, 2022 · aa5d49d · aa5d49d
1 parent 30c0e73
commit aa5d49d
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/.../java/io/camunda/zeebe/engine/processing/deployment/transform/DmnResourceTransformer.java b/.../java/io/camunda/zeebe/engine/processing/deployment/transform/DmnResourceTransformer.java
@@ -176,7 +176,8 @@ private long appendMetadataToDeploymentEvent(
             latestDrg -> {
               final int latestVersion = latestDrg.getDecisionRequirementsVersion();
               final boolean isDuplicate =
-                  isDuplicate(resource, checksum, latestDrg)
+                  hasSameResourceNameAs(resource, latestDrg)
+                      && hasSameChecksumAs(checksum, latestDrg)
                       && hasSameDecisionRequirementsKeyAs(parsedDrg.getDecisions(), latestDrg);
 
               if (isDuplicate) {
@@ -236,13 +237,14 @@ private long appendMetadataToDeploymentEvent(
     return drgRecord.getDecisionRequirementsKey();
   }
 
-  private boolean isDuplicate(
-      final DeploymentResource resource,
-      final DirectBuffer checksum,
-      final PersistedDecisionRequirements drg) {
+  private boolean hasSameResourceNameAs(
+      final DeploymentResource resource, final PersistedDecisionRequirements drg) {
+    return drg.getResourceName().equals(resource.getResourceNameBuffer());
+  }
 
-    return drg.getResourceName().equals(resource.getResourceNameBuffer())
-        && drg.getChecksum().equals(checksum);
+  private boolean hasSameChecksumAs(
+      final DirectBuffer checksum, final PersistedDecisionRequirements drg) {
+    return drg.getChecksum().equals(checksum);
   }
 
   private boolean hasSameDecisionRequirementsKeyAs(