Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BulkResponse Error not logged correctly, leading to NPE #23523

Closed
2 tasks done
PHWaechtler opened this issue Oct 15, 2024 · 1 comment
Closed
2 tasks done

BulkResponse Error not logged correctly, leading to NPE #23523

PHWaechtler opened this issue Oct 15, 2024 · 1 comment
Assignees
@PHWaechtler
Labels
component/optimize Related to Optimize component/team kind/bug Categorizes an issue or PR as a bug qa/notNeeded This issue does not require QA review support Marks an issue as related to a customer support request version:8.6.2 version:8.7.0-alpha1 Label that represents issues released on verions 8.7.0-alpha1

Comments

@PHWaechtler
Copy link
Contributor

PHWaechtler commented Oct 15, 2024 •
edited
Loading

Describe the bug

While migrating ES code, an issue was introduced when logging errors for bulkrequests. The log expects each item in a given bulkResponse to have a printable error. However, only some items may have errors so this can lead to an NPE while logging.

Expected behaviour

No NPE during logging

To Reproduce

Not easily reproducable, skip QA

Environment observed:

  • Optimize mode(s): 7 and 8
  • Optimize version(s): needs merged to main and 8.6
  • Database(s) (Elasticsearch/OpenSearch): ES

Links

https://jira.camunda.com/browse/SUPPORT-24008

Breakdown

Pull Requests
Preview Give feedback
  1. fix: avoid npe when logging bulkresponse errors #23637
    backport stable/optimize-8.6
  2. [Backport stable/optimize-8.6] fix: avoid npe when logging bulkresponse errors #23671
    component/optimize

Bug Lifecycle

For managing the issue lifecycle, please use the workflow commands. You can see the available
commands by writing /help as a comment on this issue.

QA Verification

Is this bug reproducible?

  • Yes. If so:
    • The bug description is clear
    • The steps to reproduce are clear
    • The environments observed are correct and complete
  • No

Review

Engineering Review

  • All code targeting the main branch has been reviewed by at least one Engineer
  • The PR targeting the main branch has been approved by the reviewing Engineer
  • If the API has changed, the API documentation is updated
  • All other PRs (docs, controller etc.) in the breakdown have been approved

QA Review

  • The change is implemented as described on all target environments/versions/modes
  • The documentation changes are as expected

Completion

  • All Review stages are successfully completed
  • All associated PRs are merged to the main branch(es) and stable branches
  • The correct version labels are applied to the issue
@PHWaechtler PHWaechtler added kind/bug Categorizes an issue or PR as a bug component/optimize Related to Optimize component/team labels Oct 15, 2024
@PHWaechtler PHWaechtler self-assigned this Oct 15, 2024
@PHWaechtler PHWaechtler added the support Marks an issue as related to a customer support request label Oct 15, 2024
@optimize-ci optimize-ci bot assigned RobertDorlan and unassigned PHWaechtler Oct 15, 2024
@PHWaechtler PHWaechtler mentioned this issue Oct 15, 2024
Closed
1 task
@PHWaechtler
Copy link
Contributor Author

For reference, here is the Opt7 ticket

@PHWaechtler PHWaechtler added the qa/notNeeded This issue does not require QA review label Oct 16, 2024
PHWaechtler added a commit that referenced this issue Oct 16, 2024
@PHWaechtler
fix: avoid npe when logging bulkresponse errors
3e609a3 
related to #23523
@PHWaechtler PHWaechtler mentioned this issue Oct 16, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Oct 17, 2024
@PHWaechtler
fix: avoid npe when logging bulkresponse errors (#23637)
4602478 
related to #23523

## Description
Avoid NPEs when logging bulkresponse errors. This also needs backported
to 8.6

<!-- Describe the goal and purpose of this PR. -->

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] for CI changes:
- [ ] structural/foundational changes signed off by [CI
DRI](https://github.com/cmur2)
- [ ]
[ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml)
modifications comply with ["Unified CI"
requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria)

## Related issues

related to #23523
backport-action pushed a commit that referenced this issue Oct 17, 2024
@PHWaechtler @github-actions
fix: avoid npe when logging bulkresponse errors
8d8b8fd 
related to #23523

(cherry picked from commit 3e609a3)
@backport-action backport-action mentioned this issue Oct 17, 2024
Merged
PHWaechtler added a commit that referenced this issue Oct 17, 2024
@PHWaechtler
[Backport stable/optimize-8.6] fix: avoid npe when logging bulkrespon…
46759a3 
…se errors (#23671)

# Description
Backport of #23637 to `stable/optimize-8.6`.

relates to #23523 #23523
original author: @PHWaechtler
@camundait camundait added the version:8.7.0-alpha1 Label that represents issues released on verions 8.7.0-alpha1 label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PHWaechtler PHWaechtler

Labels
component/optimize Related to Optimize component/team kind/bug Categorizes an issue or PR as a bug qa/notNeeded This issue does not require QA review support Marks an issue as related to a customer support request version:8.6.2 version:8.7.0-alpha1 Label that represents issues released on verions 8.7.0-alpha1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PHWaechtler @camundait @RobertDorlan