Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution listeners on processes or participants are not shown in Operate UI #24287

Closed
5 tasks
pedesen opened this issue Nov 1, 2024 · 6 comments
Closed
5 tasks
Assignees
Labels
component/frontend Related to a frontend component component/operate Related to the Operate component/team kind/bug Categorizes an issue or PR as a bug support Marks an issue as related to a customer support request version:8.7.0-alpha3

Comments

@pedesen
Copy link
Contributor

pedesen commented Nov 1, 2024

SUPPORT-24288

Describe the bug

Instance listeners can not be inspected in the Operate UI when they are defined on a process root or on a participant.

To Reproduce (case A: execution listener on root process)

Steps to reproduce the behavior:

  1. Deploy execution-listener-on-root.bpmn (from example-diagrams.zip)
  2. Create a task worker with type foo
  3. Create an instance for execution-listener-on-root.bpmn process
  4. Navigate to instance details view for this instance

Current behavior

When clicking on the root process in the instance history or deselect any element from the diagram, there is no execution listener tab visible, even though there are execution listeners on the root of the process.

Expected behavior

The execution listener tab should be visible and contain listeners when clicking on the root process in the instance history or deselect any element from the diagram.


To Reproduce (case B: execution listener on participant)

Steps to reproduce the behavior:

  1. Deploy execution-listener-on-participant.bpmn example-diagrams.zip)
  2. Create a task worker with type foo
  3. Create an instance for execution-listener-on-participant.bpmn process
  4. Navigate to instance details view for this instance

Current behavior

The participant on the diagram is not clickable, so the execution listener tab is never shown for listeners on the participant.

Expected behavior

Participants should be selectable and show related listeners when selected.

Environment

  • OS: [e.g. MacOS]
  • Browser: [e.g. chrome, safari]
  • Operate Version: [e.g. 8.1]

Additional context

example-diagrams.zip


Acceptance Criteria

  • Backport to 8.6

Definition of Ready - Checklist

  • The bug has been reproduced by the assignee in the environment compatible with the provided one; otherwise, the issue is closed with a comment
  • The issue has a meaningful title, description, and testable acceptance criteria
  • The issue has been labeled with an appropriate Bug-area label
  • Necessary screenshots, screen recordings, or files are attached to the bug report

For UI changes required to solve the bug:

  • Design input has been collected by the assignee

Implementation

🔍 Root Cause Analysis

💭 Proposed Solution

👉 Handover Dev to QA

  • Changed components:
  • Side effects on other components:
  • Handy resources:
    BPMN/DMN models, plugins, scripts, REST API endpoints + example payload, etc :
  • Example projects:
  • Commands/Steps needed to test; Versions to validate:
  • Docker file / HELM chart : in case that it needed to be tested via docker share the version contain the fixed along with version of other services .
  • Release version ( in which version this fixed/feature will be released):

📗 Link to the test case

User can see the Listeners tab in the details view when a listener is added to root process or participant elements

@pedesen pedesen added kind/bug Categorizes an issue or PR as a bug support Marks an issue as related to a customer support request component/operate Related to the Operate component/team component/frontend Related to a frontend component labels Nov 1, 2024
@vitorwtavares
Copy link
Contributor

@ArezooAzar To test this you can simply follow the same steps to reproduce and example bpmn processes listed in the description of this issue. The expected behavior is also described there (basically the listeners attached to the process or participant (root flow node on Instance History panel) should be visible.

github-merge-queue bot pushed a commit that referenced this issue Dec 9, 2024
#25249)

## Description

- Adds support for showing listeners attached to processes (root node on
Instance History) as well as in participants

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [ ] for CI changes:
- [ ] structural/foundational changes signed off by [CI
DRI](https://github.com/cmur2)
- [ ]
[ci.yml](https://github.com/camunda/camunda/blob/main/.github/workflows/ci.yml)
modifications comply with ["Unified CI"
requirements](https://github.com/camunda/camunda/wiki/CI-&-Automation#workflow-inclusion-criteria)

## Related issues

related to #24287
@ArezooAzar
Copy link

@vitorwtavares: Where can I find the fix? Can you share an image tag or preview environment link where I can test it?

@ThorbenLindhauer
Copy link
Member

@ArezooAzar you can test with snapshot images as the fix has been merged to main

@ArezooAzar ArezooAzar self-assigned this Dec 12, 2024
@ArezooAzar
Copy link

@vitorwtavares : please review the test case here.

@ArezooAzar
Copy link

@ArezooAzar you can test with snapshot images as the fix has been merged to main

@ThorbenLindhauer : Thank you for your reply. There were some issues with the snapshot earlier, but they have been resolved now. I tested it in the SaaS environment.

@vitorwtavares
Copy link
Contributor

vitorwtavares commented Dec 12, 2024

@vitorwtavares : please review the test case here.

Looks good! Can we mark the issue as done?

EDIT: Confirmed QA is done with @ArezooAzar on Slack, so this issue can be marked as Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/frontend Related to a frontend component component/operate Related to the Operate component/team kind/bug Categorizes an issue or PR as a bug support Marks an issue as related to a customer support request version:8.7.0-alpha3
Projects
None yet
Development

No branches or pull requests

5 participants