added region property to client properties #11870

ogkunald · 2023-03-01T13:25:53Z

Description

added region property to the client configuration properties

Related issues

closes #11846

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

The changes are backwards compatibility with previous versions
If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

There are unit/integration tests that verify all acceptance criterias of the issue
New tests are written to ensure backwards compatibility with further versions
The behavior is tested manually
The change has been verified by a QA run
The impact of the changes is verified by a benchmark

Documentation:

The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

Please refer to our review guidelines.

CLAassistant · 2023-03-01T13:26:01Z

All committers have signed the CLA.

korthout

Thanks @ogkunald. This looks great! 🚀

👍 Code and tests are perfect

❌ Please rebase and squash your commits into one or more commits with meaningful messages that follow our commit message guidelines. By writing meaningful commit messages, future code readers may be better equipped to understand why these changes were made. The consistency of the message types also helps us to keep our commit history easy to read.

github-actions · 2023-03-03T08:31:38Z

Test Results

1 003 files ±  0 1 003 suites ±0 1h 54m 5s ⏱️ + 4m 28s
7 985 tests - 84 7 975 ✔️ - 84 10 💤 ±0 0 ❌ ±0
8 184 runs - 82 8 174 ✔️ - 82 10 💤 ±0 0 ❌ ±0

Results for commit 4bd5eeb. ± Comparison against base commit 867b877.

This pull request removes 636 and adds 552 tests. Note that renamed tests count towards both.

DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={x=1, y=true, z=[1, 2, 3]}
io.camunda.zeebe.engine.processing.bpmn.activity.OutputMappingTest ‑ shouldApplyOutputMapping[0: io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@4b93a232]
io.camunda.zeebe.engine.processing.bpmn.activity.OutputMappingTest ‑ shouldApplyOutputMapping[1: io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@6c6fdf5d]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=BUSINESS_RULE_TASK, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@6644bdf5, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=CALL_ACTIVITY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@4fa8297b, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=END_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@5d404a3c, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_BASED_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@283bb8b7, variables={correlationKey=value}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_SUB_PROCESS, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@10f8e2d2, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EXCLUSIVE_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@e8c84eb, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=INTERMEDIATE_CATCH_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@66048ac4, variables={correlationKey=value}]]
…

DmnEvaluationTest If successfully evaluated, the output ‑ Should return a message pack output[6] value={z=[1, 2, 3], y=true, x=1}
io.camunda.zeebe.client.ZeebeClientTest ‑ shouldCloudBuilderBuildProperClientWithRegionPropertyNotProvided
io.camunda.zeebe.client.ZeebeClientTest ‑ shouldCloudBuilderBuildProperClientWithRegionPropertyProvided
io.camunda.zeebe.engine.processing.bpmn.activity.OutputMappingTest ‑ shouldApplyOutputMapping[0: io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@2728e166]
io.camunda.zeebe.engine.processing.bpmn.activity.OutputMappingTest ‑ shouldApplyOutputMapping[1: io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@1d81dece]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=BUSINESS_RULE_TASK, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@5125558b, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=CALL_ACTIVITY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@673d73da, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=END_EVENT, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@2836374, variables={}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_BASED_GATEWAY, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@69a61267, variables={correlationKey=value}]]
io.camunda.zeebe.engine.processing.processinstance.CreateProcessInstanceSupportedElementTest ‑ testProcessInstanceCanStartAtElementType[Scenario[type=EVENT_SUB_PROCESS, modelInstance=io.camunda.zeebe.model.bpmn.impl.BpmnModelInstanceImpl@1c586bb6, variables={}]]
…

♻️ This comment has been updated with latest results.

korthout · 2023-03-03T08:35:26Z

Seems that checkstyle detected a minor code style issue (just some training whitespace):

[INFO] --- maven-checkstyle-plugin:3.2.0:check (validate-java) @ zeebe-client-java ---
[INFO] There are 2 errors reported by Checkstyle 10.8.0 with check/.checkstyle.xml ruleset.
Error: src/main/java/io/camunda/zeebe/client/ClientProperties.java:[104] (regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.
Error: src/main/java/io/camunda/zeebe/client/ClientProperties.java:[109] (regexp) Regexp: Line matches the illegal pattern 'Trailing whitespace'.

ogkunald · 2023-03-03T11:34:12Z

Hi @korthout As per your suggestion.
I have made following changes-

Removed unwanted trailing whitespaces
Single commit with meaningful message.

Please review and let me know.
Thanks.

korthout

Awesome! Thanks for the changes @ogkunald 🙇

LGTM 👍

bors merge

ghost · 2023-03-03T14:02:34Z

Build succeeded:

Test summary

korthout · 2023-03-03T14:17:40Z

/backport

backport-action · 2023-03-03T14:18:03Z

Successfully created backport PR for stable/8.0:

[Backport stable/8.0] added region property to client properties #11915

backport-action · 2023-03-03T14:18:09Z

Successfully created backport PR for stable/8.1:

[Backport stable/8.1] added region property to client properties #11916

11837: [Backport stable/8.0] fix: don't re-wrap runtime exceptions thrown inside a transaction r=oleschoenburg a=oleschoenburg Manual backport of #11701 without the last commit which contained a test that is not straight forward to re-implement without the stream-platform abstraction. 11915: [Backport stable/8.0] added region property to client properties r=korthout a=backport-action # Description Backport of #11870 to `stable/8.0`. relates to #11846 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> Co-authored-by: ogkunald <kunaldongare111@gmail.com>

11916: [Backport stable/8.1] added region property to client properties r=korthout a=backport-action # Description Backport of #11870 to `stable/8.1`. relates to #11846 Co-authored-by: ogkunald <kunaldongare111@gmail.com>

11837: [Backport stable/8.0] fix: don't re-wrap runtime exceptions thrown inside a transaction r=oleschoenburg a=oleschoenburg Manual backport of #11701 without the last commit which contained a test that is not straight forward to re-implement without the stream-platform abstraction. 11915: [Backport stable/8.0] added region property to client properties r=korthout a=backport-action # Description Backport of #11870 to `stable/8.0`. relates to #11846 Co-authored-by: Ole Schönburg <ole.schoenburg@gmail.com> Co-authored-by: ogkunald <kunaldongare111@gmail.com> Co-authored-by: Nico Korthout <nico.korthout@camunda.com>

related to #11870

ogkunald mentioned this pull request Mar 2, 2023

Zeebe java client didn't get the region from the configuration #11846

Closed

korthout requested changes Mar 3, 2023

View reviewed changes

ogkunald force-pushed the 11846-add-region-property branch 2 times, most recently from 392094d to f2b087b Compare March 3, 2023 10:17

ogkunald closed this Mar 3, 2023

ogkunald force-pushed the 11846-add-region-property branch from f2b087b to 867b877 Compare March 3, 2023 10:25

fix(clients/java): added region property in cloud client properties

4bd5eeb

ogkunald reopened this Mar 3, 2023

korthout added backport stable/8.0 labels Mar 3, 2023

korthout approved these changes Mar 3, 2023

View reviewed changes

ghost merged commit a13af2e into camunda:main Mar 3, 2023

backport-action mentioned this pull request Mar 3, 2023

[Backport stable/8.0] added region property to client properties #11915

Merged

backport-action mentioned this pull request Mar 3, 2023

[Backport stable/8.1] added region property to client properties #11916

Merged

deepthidevaki added the release/8.0.12 label Mar 7, 2023

megglos added the version:8.1.9 Marks an issue as being completely or in parts released in 8.1.9 label Mar 13, 2023

github-merge-queue bot pushed a commit that referenced this pull request Aug 9, 2024

improve(task analysis): small UI tweaks (#11894)

425a81e

related to #11870

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added region property to client properties #11870

added region property to client properties #11870

ogkunald commented Mar 1, 2023 •

edited

Loading

CLAassistant commented Mar 1, 2023 •

edited

Loading

korthout left a comment •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading

korthout commented Mar 3, 2023

ogkunald commented Mar 3, 2023

korthout left a comment

ghost commented Mar 3, 2023

korthout commented Mar 3, 2023

backport-action commented Mar 3, 2023

backport-action commented Mar 3, 2023

added region property to client properties #11870

added region property to client properties #11870

Conversation

ogkunald commented Mar 1, 2023 • edited Loading

Description

Related issues

Definition of Done

CLAassistant commented Mar 1, 2023 • edited Loading

korthout left a comment • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Mar 3, 2023 • edited Loading

Test Results

korthout commented Mar 3, 2023

ogkunald commented Mar 3, 2023

korthout left a comment

Choose a reason for hiding this comment

ghost commented Mar 3, 2023

korthout commented Mar 3, 2023

backport-action commented Mar 3, 2023

backport-action commented Mar 3, 2023

ogkunald commented Mar 1, 2023 •

edited

Loading

CLAassistant commented Mar 1, 2023 •

edited

Loading

korthout left a comment •

edited

Loading

github-actions bot commented Mar 3, 2023 •

edited

Loading